Skip to content

fix(typescript): add trailing commas to as const enums#23277

Open
scarf005 wants to merge 1 commit intoOpenAPITools:masterfrom
scarf005:fix/typescript-as-const-trailing-commas
Open

fix(typescript): add trailing commas to as const enums#23277
scarf005 wants to merge 1 commit intoOpenAPITools:masterfrom
scarf005:fix/typescript-as-const-trailing-commas

Conversation

@scarf005
Copy link
Contributor

@scarf005 scarf005 commented Mar 17, 2026

Summary

  • add trailing commas to as const enum objects in typescript-angular, typescript-fetch, and typescript-nestjs-server
  • update generated samples and add shared regression coverage

continuation of #23275

PR opened by gpt-5.4 xhigh on opencode


Summary by cubic

Generate as const enum objects with trailing commas to reduce diff noise and align with common TS style across generators. Updates templates for typescript-angular, typescript-fetch, and typescript-nestjs-server, and adds shared regression coverage across generators.

  • Bug Fixes
    • Always emit trailing commas in enum objects in typescript-angular, typescript-fetch, and typescript-nestjs-server templates.
    • Updated generated samples to reflect the new formatting.
    • Added a shared test to enforce trailing commas across typescript-angular, typescript-fetch, typescript-nestjs-server, and typescript-axios.

Written for commit d9cb3b1. Summary will update on new commits.

@scarf005 scarf005 marked this pull request as ready for review March 24, 2026 00:40
Copy link
Contributor

@cubic-dev-ai cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 100 files

Note: This PR contains a large number of files. cubic only reviews up to 75 files per PR, so some files may not have been reviewed.

…23275)

Keep enum object diffs smaller across Angular, Fetch, and NestJS server generators.
@scarf005 scarf005 force-pushed the fix/typescript-as-const-trailing-commas branch from b11c3b1 to d9cb3b1 Compare March 24, 2026 00:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant