[csharp] Add useVirtualForHooks option #20705
Open
+13
−4
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using C# OpenAPI clients with HttpClient or RestSharp from a browser via WASM (such as in Blazor WASM) it can be necessary to customize the HttpClient or RestRequest before sending it. In my case I need to invoke
httpRequestMessage.SetBrowserRequestCredentials(BrowserRequestCredentials.Include)
on the underlying HTTP request so that the browser's secure cookies are included with the request.To achieve this in a backwards-compatible way I've introduced the
useVirtualForHooks
option for C#, which alters the definition of theInterceptRequest
andInterceptResponse
hooks to becomepublic virtual
methods, allowing the end-user to define custom HTTP request hooks. Technically I only need theInterceptRequest
hook, but I've includedInterceptResponse
for consistency and because it might be useful for other situations in a browser context.CC: @wing328 This is the result of our discussion about #20015
CC: C# technical committee (@mandrean @shibayan @Blackclaws @lucamazzanti @iBicha)
Fixes #14609
PR checklist
Commit all changed files.
This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
These must match the expectations made by your contribution.
You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example
./bin/generate-samples.sh bin/configs/java*
.IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
master
(upcoming7.x.0
minor release - breaking changes with fallbacks),8.0.x
(breaking changes without fallbacks)