Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Python] Add ca_cert_data parameter #20697

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

micolous
Copy link

@micolous micolous commented Feb 20, 2025

The ca_cert_data parameter lets a client validate a server's CA certificate chain using a variable/constant containing PEM (str) or DER (bytes) data, rather than needing to reference a file on disk.

Naming is based on what urllib3 calls this parameter.

I've applied a similar patch to some locally generated bindings for asyncio and urllib3, and it's working there.

@cbornet (2017/09) @tomplus (2018/10) @krjakbrjak (2023/02) @fa0311 (2023/10) @multani (2023/10)

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package || exit
    ./bin/generate-samples.sh ./bin/configs/*.yaml || exit
    ./bin/utils/export_docs_generators.sh || exit
    
    (For Windows users, please run the script in Git BASH)
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
  • File the PR against the correct branch: master (upcoming 7.x.0 minor release - breaking changes with fallbacks), 8.0.x (breaking changes without fallbacks)
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

@micolous micolous changed the title Add ca_cert_data parameter to Python client. [Python] Add ca_cert_data parameter Feb 21, 2025
@micolous micolous marked this pull request as ready for review February 21, 2025 06:10
@micolous
Copy link
Author

Now ready for review. I've tested this with asyncio as well now, that's working as I expect.

CI failures were due to me using some Python 3.10+ syntax (str | bytes instead of Union[str, bytes]).

This lets a client validate a server's CA certificate chain using a
variable/constant containing PEM (`str`) or DER (`bytes`) data, rather than
needing to reference a file on disk.
Copy link
Contributor

@multani multani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants