Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Rust] Fix enum variant name generation #20689

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

whirm
Copy link
Contributor

@whirm whirm commented Feb 19, 2025

Found out that oneOf's enum variant names were not correctly generated and datatypes like Vec<foo::bar::Baz> would end up as Baz instead of VecOfBaz generating duplicates in cases like the test included.

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package || exit
    ./bin/generate-samples.sh ./bin/configs/*.yaml || exit
    ./bin/utils/export_docs_generators.sh || exit
    
    (For Windows users, please run the script in Git BASH)
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
  • File the PR against the correct branch: master (upcoming 7.x.0 minor release - breaking changes with fallbacks), 8.0.x (breaking changes without fallbacks)
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

@whirm whirm changed the title WIP: test and fix enum generation from oneOf where variants contain o… WIP: [Rust] test and fix enum generation from oneOf where variants contain o… Feb 19, 2025
@whirm whirm changed the title WIP: [Rust] test and fix enum generation from oneOf where variants contain o… [Rust] test and fix enum generation from oneOf where variants contain objects Feb 19, 2025
@whirm
Copy link
Contributor Author

whirm commented Feb 19, 2025

I found this case where an enum with identically named variants ends up being generated.

Edit: Working on a fix

where variants would end up having the same name.
Datatypes like `Vec<foo::bar::Baz>` would end up as `Baz` instead of `VecOfBaz`
@whirm whirm force-pushed the fix/rust_enum_of_oneof_objects branch from a3139de to a3ca359 Compare February 20, 2025 13:55
@whirm whirm changed the title [Rust] test and fix enum generation from oneOf where variants contain objects [Rust] Fix enum variant name generation Feb 20, 2025
@whirm whirm marked this pull request as ready for review February 20, 2025 14:01
@whirm
Copy link
Contributor Author

whirm commented Feb 20, 2025

@frol, @farcaller, @richardwhiuk, @paladinzh, @jacob-pro Ready to review!

@wing328
Copy link
Member

wing328 commented Feb 22, 2025

thanks for the PR

cc @linxGnu

Copy link
Contributor

@linxGnu linxGnu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants