Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[csharp] fix "Simplify 'default' expression (IDE0034)" messages #20684

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

ffabss
Copy link

@ffabss ffabss commented Feb 18, 2025

This PR adjusts the csharp code generation to directly use default instead of default({{&dataType}}). Thereby it gets rid of a few hundred IDE0034 messages and also reduces the overall size of the code a bit.

There are a lot of changed files but essentially the changes are only in the mustache files for c#. There all occurrences of the regex default\([^)]*\) are replaced by default.

I checked the (changed) samples to verify that they still build and that the messages are gone.

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package || exit
    ./bin/generate-samples.sh ./bin/configs/*.yaml || exit
    ./bin/utils/export_docs_generators.sh || exit
    
    (For Windows users, please run the script in Git BASH)
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
  • File the PR against the correct branch: master (upcoming 7.x.0 minor release - breaking changes with fallbacks), 8.0.x (breaking changes without fallbacks)
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

@mandrean (2017/08) @shibayan (2020/02) @Blackclaws (2021/03) @lucamazzanti (2021/05) @iBicha (2023/07)

@ffabss ffabss force-pushed the csharp-fix-ide0034-messages branch from a3b1948 to c1036b5 Compare February 18, 2025 22:17
@wing328
Copy link
Member

wing328 commented Feb 19, 2025

thanks for the PR

also cc @devhl-labs

@wing328 wing328 added Client: C-Sharp Server: C-Sharp Enhancement: Code Cleanup General refactoring, removal of deprecated things, commenting, etc. labels Feb 19, 2025
@wing328 wing328 added this to the 7.12.0 milestone Feb 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Client: C-Sharp Enhancement: Code Cleanup General refactoring, removal of deprecated things, commenting, etc. Server: C-Sharp
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants