-
-
Notifications
You must be signed in to change notification settings - Fork 6.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixing multiple problems with SpringCodegen when activating ServerSentEvents #20658
base: master
Are you sure you want to change the base?
Fixing multiple problems with SpringCodegen when activating ServerSentEvents #20658
Conversation
Thanks for the PR but your commit (as shown in the Commits tab) is not linked to your Github account, which means this PR won't count as your contribution in https://github.com/OpenAPITools/openapi-generator/graphs/contributors. Let me know if you need help fixing it. |
@@ -0,0 +1,12 @@ | |||
generatorName: spring | |||
outputDir: samples/server/petstore/springboot-reactive-serverSentEvents |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can you please add the new output folder to the github workflow so that it will be tested moving forward?
https://github.com/OpenAPITools/openapi-generator/blob/master/.github/workflows/samples-spring.yaml
https://github.com/OpenAPITools/openapi-generator/blob/master/.github/workflows/samples-spring-jdk17.yaml
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added.
Fixed the email as well, thanks for pointing it out
…nd instantiate the generator. This fixes the different behavior between Test and CLI seen in OpenAPITools#17273 (comment)
… ones failing or crashing the generator are ignored for the moment.
…the specification of a sse endpoint. Fixes OpenAPITools#17271
…try. Fixing NPE when the response does not contain any schema
…ew sample to check generation
…PITools#20631) * Fixed Rust default `isAnyType` causing compiler issues. * Added tests for Rust isAnyType's * Fixed thread_test.rs
…ly=true is used (OpenAPITools#20640) * [JavaSpring] attach sources when using maven and interfaceOnly=true Closes OpenAPITools#15659 * [kotlin-spring] attach sources when using maven and interfaceOnly=true Closes OpenAPITools#15659
058f526
to
e7207c2
Compare
cc @cachescrubber (2022/02) @welshm (2022/02) @MelleD (2022/02) @atextor (2022/02) @manedev79 (2022/02) @javisst (2022/02) @borsch (2022/02) @banlevente (2022/02) @Zomzog (2022/09) @martin-mfg (2023/08) |
https://github.com/OpenAPITools/openapi-generator/actions/runs/13336520230/job/37276957271?pr=20658 please update the samples one more time when you've time UPDATE: done via 5b3014a |
cc |
This PR fixes a number of NPEs when using the spring generator with the options 'reactive' and 'serverSentEvents'.
It fixes #17271 and some similar problems, see commit 31a705c for all identified and fixed problems. The problems mainly originated from not handling $ref correctly and expecting to always have the text/event-stream media type (which is obviously not true for non-sse operations).
Additionally a sample was added, to ensure the 'petstore-with-fake-endpoints-models-for-testing' (extended with a simple sse operation) can be generated without problems.
PR checklist
Commit all changed files.
This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
These must match the expectations made by your contribution.
You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example
./bin/generate-samples.sh bin/configs/java*
.IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
master
(upcoming7.x.0
minor release - breaking changes with fallbacks),8.0.x
(breaking changes without fallbacks)