Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GO] fix: correctly use oneOf path parameters #14029

Closed
wants to merge 2 commits into from

Conversation

NickUfer
Copy link
Contributor

@NickUfer NickUfer commented Nov 15, 2022

Fixes #14028

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh
    ./bin/utils/export_docs_generators.sh
    
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    For Windows users, please run the script in Git BASH.
  • File the PR against the correct branch: master (6.3.0) (minor release - breaking changes with fallbacks), 7.0.x (breaking changes without fallbacks)
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

@antihax (2017/11) @grokify (2018/07) @kemokemo (2018/09) @jirikuncar (2021/01) @ph4r5h4d (2021/04)

@WhoLet2DogsOut
Copy link

Hi, may I ask if it would be possible to add this fix into new version of generator? OpenApi generator is not usable for us without OneOf working properly.

@NickUfer
Copy link
Contributor Author

NickUfer commented Dec 5, 2022

Well, I don't know man. Since I created this PR a lot of stuff changed again which doesn't work or wasn't properly tested and this change can't be merged because I would have to rewrite everything to this new system which currently outputs reflect.Value+value in a query parameter... and right now rewriting this is the last thing I want to do as it is annoying to me.
Since 2 months I try to use this lib, and all the time I run into the next bug. I just want to finish what I actually build with this lib man

@NickUfer NickUfer closed this Dec 5, 2022
@NickUfer
Copy link
Contributor Author

NickUfer commented Dec 5, 2022

I will actually just maintain my own private fork of the version I created this PR for and add more fixes to it if I need them. I will come back in 1 or 2 years to this project and hope it is more stable. Right now there are too many problems and to see that more bugs are added through refactoring or whatever it is... no thanks

@WhoLet2DogsOut
Copy link

Totally understand, thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG][GO] oneOf path parameters pointer is used as path parameter in request
2 participants