Skip to content

Conversation

@gabriel-peze
Copy link

Proposed changes

  • Add common process for injector/collector domains integrations

Testing Instructions

  1. Start the atomic red team collector and check his integrated payloads on the platform, there should hold the domains

@gabriel-peze gabriel-peze changed the base branch from main to release/current December 3, 2025 15:15
@gabriel-peze gabriel-peze self-assigned this Dec 4, 2025
@gabriel-peze gabriel-peze added the filigran team use to identify PR from the Filigran team label Dec 4, 2025
@gabriel-peze gabriel-peze marked this pull request as ready for review December 5, 2025 11:04
Copy link
Member

@antoinemzs antoinemzs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For these two reasons:

  • this patch contains duplicated logic
  • the duplication is only used by the ATR collector

please can you move the duplicated logic away from pyoaev and into the ATR collector's own private code.

In the future, this default assignment of security domain logic should be integrated in the core API.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like we are duplicating this logic in both core and pyoaev. What are the plans for long term cohesion of this duplicated keyword assignment logic?

@gabriel-peze gabriel-peze merged commit cccff9e into release/current Dec 16, 2025
4 checks passed
@gabriel-peze gabriel-peze deleted the issue/4266 branch December 16, 2025 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

filigran team use to identify PR from the Filigran team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[SCV] Assign Security Domains to Injectors Contract [SCV] Categorize existing payloads into domains

3 participants