-
Notifications
You must be signed in to change notification settings - Fork 5
[client] feat(SCV): add domains management on contract creations (#4266) #153
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
615669b to
46df5e3
Compare
4dac22b to
2f45b9d
Compare
antoinemzs
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For these two reasons:
- this patch contains duplicated logic
- the duplication is only used by the ATR collector
please can you move the duplicated logic away from pyoaev and into the ATR collector's own private code.
In the future, this default assignment of security domain logic should be integrated in the core API.
pyoaev/security_domain/builder.py
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like we are duplicating this logic in both core and pyoaev. What are the plans for long term cohesion of this duplicated keyword assignment logic?
45ff473 to
9ccb1cf
Compare
Proposed changes
Testing Instructions