Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: enforce more lint rules in codebase #101

Merged

Conversation

R1kaB3rN
Copy link
Member

@R1kaB3rN R1kaB3rN commented Aug 9, 2024

Related to #50

Uses ruff instead of pylint as the project's linter to enforce more lint rules.

Changes

  • enforced function types
  • add ruff.toml
  • enforced single quotes
  • enforced format strings
  • enforced docstrings for each function
  • enforce a docstring format for non-gamefix modules
  • enforce a reasonable line length
  • removed #pylint: disable=C0103 from gamefixes
  • enforced linter for all *.py files
  • enforced f-strings when possible

@R1kaB3rN R1kaB3rN force-pushed the protonfixes-refactoring branch from 9276477 to c8563b8 Compare September 1, 2024 22:50
@R1kaB3rN R1kaB3rN marked this pull request as ready for review September 1, 2024 23:11
@R1kaB3rN R1kaB3rN force-pushed the protonfixes-refactoring branch from 488d397 to 375832a Compare September 4, 2024 01:18
@R1kaB3rN R1kaB3rN force-pushed the protonfixes-refactoring branch from 375832a to dc754ba Compare September 4, 2024 01:29
@R1kaB3rN R1kaB3rN merged commit 490f513 into Open-Wine-Components:master Sep 4, 2024
1 of 2 checks passed
@R1kaB3rN R1kaB3rN deleted the protonfixes-refactoring branch September 4, 2024 01:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant