Support compatibility tools other than Proton out-of-the-box. #293
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
loathingKernel
force-pushed
the
tool_info
branch
14 times, most recently
from
fc45233 to
60315a1
Compare
|
will this make it possible to use proton-tkg ?? |
It should make possible to run any tool that works with Steam as a compatibility tool. The main constraint not addressed yet are tools that require a runtime other than |
loathingKernel
force-pushed
the
tool_info
branch
2 times, most recently
from
f4d0ab0 to
32babaa
Compare
…ommand Using the information in the compatibility tool's manifest, umu executes the tool's entry point as described by the tool with the expected runtime environment. Umu now detects when the runtime should be used and potentially use the correct runtime to do so. This also enables umu to run tools other than proton, such as luxtorpeda simply by setting `PROTONPATH=luxtorpeda` or `PROTONPATH=/path/to/not/proton`
loathingKernel
force-pushed
the
tool_info
branch
from
32babaa to
b711018
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to allow auto-configuration of compatibility tools other than Proton by using the information in
compatibilitytool.vdfandtoolmanifest.vdfmanifest files. Using this information umu can construct the proper command for each tool based on which runtime the tool depends on (if at all), the entry point of the runtime and the tool, and the type of the tool (important forwinetricksas it works only on proton). This supersedes environment variables suchUMU_NO_PROTON(PROTONPATHremains as a way to set the tool with expanded meaning) andUMU_NO_RUNTIME. These variables are retained only to force a specific configuration if required.For example
GAMEID=0 WINEPREFIX=~/Wine/umu/ UMU_LOG=debug PROTONPATH=luxtorpeda umu-runlaunchesluxtorpedathroughumu.Important changes:
vdflibrary is now a vendored dependency. It is a pure-python library and thus compatible withzipapp.UMU_NO_PROTONrenamed toUMU_NO_TOOLto avoid confusion of its purpose. This is useful if the user wants to run a linux-native binary in the runtime without a tool.UMU_NO_RUNTIMEis retained as an override if the user wants to explicitly disable the runtime even if the tool requires it. Tools that don't use the runtime do not require this to be set any more.umu-shimis always prepended to the tool's command. I have not tested this extensively but it didn't cause issues while testing with various tools and protons under X11.Things that need more consideration:
_v2-entry-pointtoumu. This rename is handled here. The same name for the entry point is also used in thesoldier, streamrt2runtime. The "new" scout-in-soldier runtime usesscout-on-soldier-entry-point-v2. If umu was to stop renaming the runtime's entry point, it should make supporting more runtimes easier.scout-in-soldier, it is a runtime which depends on another runtime. The current implementation ofSteamRuntimeclass doesn't handle a runtime using another runtime. Should it be implemented and remain unused for now?UMU_NO_TOOLenv variable. ThePROTONPATHenv variable could be used to define the runtime that should be used to run a linux-native executable in the form ofPROTONPATH="soldier/scout/etc". This should makeUMU_NO_TOOLobsolete.umu-shimis always prepended to the tool's command. I have no tested this extensively but it didn't cause issues while testing with various tools and protons.Marked as draft for now pending the first round of reviews.