Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Attempt to find game working directory #138

Closed
wants to merge 10 commits into from

Conversation

R1kaB3rN
Copy link
Member

@R1kaB3rN R1kaB3rN commented Jul 4, 2024

Related to #63

@Aqa-Ib
Copy link

Aqa-Ib commented Jul 4, 2024

Excuse me, but I don't understand how may I execute the executable contained in the subdir considering this patch ?

@R1kaB3rN R1kaB3rN marked this pull request as ready for review July 4, 2024 20:04
@R1kaB3rN
Copy link
Member Author

R1kaB3rN commented Jul 5, 2024

Excuse me, but I don't understand how may I execute the executable contained in the subdir considering this patch ?

In the patch at that time, all you needed to do was simply run the GOG game by passing the absolute path then umu would change to the correct directory for you. As a result, you wouldn't need to worry about changing to any directory in your helper script or before running umu from the CLI.

And long story short, this feature has been put on hold.

Explanation

After some feedback from the team, it was determined that it wouldn't really be too useful for clients who are already in a position to change to the correct directory and it risks conflicting with the user's target directory set in the client. Since then, the direction of the patch has changed to only finding the correct directory for Steam games but that has also been put on hold too due to the uncertainty of whether to even support that use case.

If this feature were to be added though, it'd probably be in the configuration file usage as it wouldn't get in the way of client apps, thus posing no risk. Also, it'd need to be really useful to those users.

@R1kaB3rN R1kaB3rN closed this Jul 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants