Fix configuring Steam game drive and misc #104
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- The container runtime framework expects the user's filesystem to conform to the File Hierarchy Standard (FHS) and for library paths to be found in /usr/lib, /usr/lib32, /usr/lib64, /usr/lib/x86_64-linux-gnu or /usr/lib/i386-linux-gnu. Currently, the launcher hard codes the paths /usr/lib and /usr/lib32, which should only be valid for Archlinux and its derivatives. While this currently works and has not been reported to cause any issue, this is still wrong since distributions like Debian or Fedora use different paths (e.g., /usr/lib64 and /usr/lib). To reliably find the user's library paths, we need to use the ldconfig binary
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes library paths for Steam game drive and updates ruff.toml to enforce the
encodingargument when opening files. As a result, the STEAM_RUNTIME_LIBRARY_PATH variable should be represented accurately across distributions as long as the filesystem is FHS compliant and are officially supported by the runtime container framework.