Add [Open Library] & Library Work Flow #20

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Open

dethan3 wants to merge 9 commits into Open-Source-Bazaar:main from dethan3:main

Member

dethan3 commented Feb 24, 2025 •

edited by pull-request-badge bot

Loading

Checklist（清单）:

Labels
Assignees
Reviewers

Add [Open Library],
Use the documentation to quickly start operating Open Library.

Closes #15

dethan3 added 7 commits

February 24, 2025 07:49


          library flow

74174bd


          [feat] Initial open-library homepage, component & hook fix

07745ad


          feat: customize Open Library layout and styling

e10b0b1


          fix: resolve import sorting and TS annotation issues

69dbf8b


          feat: implement Open Library basic framework with multilingual support

a72c2ee


          fix: replace <a> tags with Next.js <Link> components and fix TypeScri…

23870d8

…pt errors


          feat: Complete MVP layout improvements

99320ce

TechQuery added the feature label

TechQuery self-requested a review

July 8, 2025 18:20


          Merge upstream/main and resolve conflicts

08d2e72

TechQuery requested changes

View reviewed changes

Member

TechQuery left a comment

很多问题在不同文件都有，不一一列举，但都要改
软件开发要一个一个模块来，代码量太大对开发者、reviewer、AI 都有巨大上下文负担，很容易跑偏、卡死
以后要在看板上多拆几个 issue，不要闷头搞很久后发一个差不多做完整个项目的巨大 PR……

.husky/pre-commit Show resolved Hide resolved

components/Navigator/MainNavigator.tsx Show resolved Hide resolved

package.json Show resolved Hide resolved

translation/zh-CN.ts Outdated

    
                donate_books: '捐赠书籍',

                how_it_works: '运作方式',

                how_it_works_description: '三个简单步骤借阅社区书籍',

                step_1_find_book: '1. 寻找书籍',

Member

TechQuery Jul 9, 2025

数字序号放在 HTML 结构中用 <ol /> 实现。

translation/zh-CN.ts Outdated

    
                available: '可借阅',

                borrowed: '已借出',

                reset_filters: '重置筛选',

                showing_books: '显示 {0} 本书，共 {1} 本',

Member

TechQuery Jul 9, 2025

MobX-i18n 的翻译模板用的是箭头函数：https://github.com/idea2app/Next-Bootstrap-ts/blob/fba9a37e772550e384e608caddf7e220c79edb2e/translation/zh-CN.ts#L28-L29

pages/open-library/book/[id].tsx

    
                              </Col>

                              <Col md={9}>

                                <h1>{book.title}</h1>

                                <h5 className="text-muted mb-3">by {book.author}</h5>

Member

TechQuery Jul 9, 2025

作者信息不是标题，一般用 <cite />：https://developer.mozilla.org/en-US/docs/Web/HTML/Reference/Elements/cite

pages/open-library/book/[id].tsx

Comment on lines +307 to +324

    
                                <Row className="mt-4">

                                  <Col sm={6} md={3} className="mb-3">

                                    <div className="text-muted small">ISBN</div>

                                    <div>{book.isbn || 'N/A'}</div>

                                  </Col>

                                  <Col sm={6} md={3} className="mb-3">

                                    <div className="text-muted small">Publisher</div>

                                    <div>{book.publisher || 'N/A'}</div>

                                  </Col>

                                  <Col sm={6} md={3} className="mb-3">

                                    <div className="text-muted small">Published</div>

                                    <div>{book.publishYear || 'N/A'}</div>

                                  </Col>

                                  <Col sm={6} md={3} className="mb-3">

                                    <div className="text-muted small">Pages</div>

                                    <div>{book.pageCount || 'N/A'}</div>

                                  </Col>

                                </Row>

Member

TechQuery Jul 9, 2025

Suggested change

      
                              <Row className="mt-4">
          
                                <Col sm={6} md={3} className="mb-3">
          
                                  <div className="text-muted small">ISBN</div>
          
                                  <div>{book.isbn || 'N/A'}</div>
          
                                </Col>
          
                                <Col sm={6} md={3} className="mb-3">
          
                                  <div className="text-muted small">Publisher</div>
          
                                  <div>{book.publisher || 'N/A'}</div>
          
                                </Col>
          
                                <Col sm={6} md={3} className="mb-3">
          
                                  <div className="text-muted small">Published</div>
          
                                  <div>{book.publishYear || 'N/A'}</div>
          
                                </Col>
          
                                <Col sm={6} md={3} className="mb-3">
          
                                  <div className="text-muted small">Pages</div>
          
                                  <div>{book.pageCount || 'N/A'}</div>
          
                                </Col>
          
                              </Row>
          
                              <Row as="ul" className="list-unstyled mt-4 g-3" sm={2} md={4}>
          
                                <Col as="li">
          
                                  <div className="text-muted small">ISBN</div>
          
                                  <div>{book.isbn || 'N/A'}</div>
          
                                </Col>
          
                                <Col as="li">
          
                                  <div className="text-muted small">Publisher</div>
          
                                  <div>{book.publisher || 'N/A'}</div>
          
                                </Col>
          
                                <Col as="li">
          
                                  <div className="text-muted small">Published</div>
          
                                  <div>{book.publishYear || 'N/A'}</div>
          
                                </Col>
          
                                <Col as="li">
          
                                  <div className="text-muted small">Pages</div>
          
                                  <div>{book.pageCount || 'N/A'}</div>
          
                                </Col>
          
                              </Row>

pages/open-library/book/[id].tsx

Comment on lines +351 to +352

    
                              {book.reviews && book.reviews.length > 0 ? (

                                <div>

Member

TechQuery Jul 9, 2025

Suggested change

      
                            {book.reviews && book.reviews.length > 0 ? (
          
                              <div>
          
                            {book.reviews?.[0] ? (
          
                              <>

pages/open-library/book/[id].tsx

Comment on lines +404 to +405

    
                                <div className="table-responsive">

                                  <table className="table table-hover">

Member

TechQuery Jul 9, 2025

用 <Table />：https://react-bootstrap.github.io/docs/components/table/

pages/open-library/book/[id].tsx

Comment on lines +419 to +421

    
                                            {new Date(

                                              history.borrowDate,

                                            ).toLocaleDateString()}

Member

TechQuery Jul 9, 2025

Suggested change

      
                                          {new Date(
          
                                            history.borrowDate,
          
                                          ).toLocaleDateString()}
          
                                          {formatDate(history.borrowDate, 'YYYY-MM-DD')}

服务端地区设置和用户浏览器通常不同，toLocaleXXX() 的结果也会不同，会出现 SSR 报错
https://web-cell.dev/web-utility/functions/formatDate.html

TechQuery added the enhancement label


          Merge remote-tracking branch 'upstream/main'

18e9c84

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement feature