Improve documentation and performance of CSync #283
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Enquier
commented
May 29, 2024
Enquier
commented
- Improving CSync performance
- Adding additional documentation for CSync,
- Updating missing JavaFX libararies for multi-platform compatibility (fixes JavaFX libraries are still not embedding correctly. #282 )
- Note this PR incorporates the SVG Capability (need to merge Feature/enriched svg #280 first)
dlamoris
reviewed
Jun 10, 2024
| @@ -161,7 +166,13 @@ private enum Processor { | |||
| DOCUMENTATION_PRE( | |||
| (element, project, objectNode) -> { | |||
| //Todo: FIgure out how to read this stuff and parse the <a tags from MD | |||
| // String doc_text = (String) Utils.getElementAttribute(element, Utils.AvailableAttribute.Documentation); | |||
| String doc_text = (String) Utils.getElementAttribute(element, Utils.AvailableAttribute.Documentation); | |||
There was a problem hiding this comment.
don't think this is completely implemented? the parsed doc isn't used anywhere, there's no mms-cf attr added, and should have a try catch surrounding it in case jsoup fails, also it'll lead to a diff since the output on mms will then be different to the model, think this should commented out and revisited later
dlamoris
reviewed
Jun 10, 2024
|
|
||
| ProjectValidator pv = new ProjectValidator(project); | ||
| pv.validate(); | ||
| ProgressStatusRunner.runWithProgressStatus(pv, "Coordinated Sync: Project Validation", true, 0); |
There was a problem hiding this comment.
is the reason why it's starting a new runner instead of calling pv.run(progressStatus) because it's changing to indeterminate?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.