Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump PLANETSCOPE stac version to 1.0.0 #55

Merged
merged 6 commits into from
Aug 13, 2024

Conversation

guss84
Copy link
Contributor

@guss84 guss84 commented Nov 9, 2023

Fixes #54

Updated the version to 1.0.0, added missing type attribute and validated the json file with https://github.com/stac-utils/stac-validator

@dthiex dthiex self-requested a review November 14, 2023 15:51
Copy link
Contributor

@dthiex dthiex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's also update the version within tests\fixtures\collection_information\PLANETSCOPE.json for consistence.

@guss84
Copy link
Contributor Author

guss84 commented Dec 7, 2023

Let's also update the version within tests\fixtures\collection_information\PLANETSCOPE.json for consistence.

Good point, updated the stac version in the test fixture as well

@guss84 guss84 assigned dthiex and unassigned guss84 Dec 7, 2023
@dthiex
Copy link
Contributor

dthiex commented Aug 12, 2024

@guss84 Can you pls. check why the tests are failing here? I checked the stac file and it looks fine. Once the tests are working again, we can merge this.

@dthiex dthiex assigned guss84 and unassigned dthiex Aug 12, 2024
@guss84
Copy link
Contributor Author

guss84 commented Aug 13, 2024

@guss84 Can you pls. check why the tests are failing here? I checked the stac file and it looks fine. Once the tests are working again, we can merge this.

The tests failed because the docker-compose script had to be updated. This was done with e967e6d

@guss84 guss84 assigned dthiex and unassigned guss84 Aug 13, 2024
@dthiex dthiex merged commit 7b75f00 into master Aug 13, 2024
4 checks passed
@dthiex dthiex deleted the fix/planetscope_1.0.0_stac_version branch August 13, 2024 12:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

PLANETSCOPE stac version
2 participants