-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue #182 add namespace support to DataCube.process
and related
#183
Conversation
related PRs for python and geopyspark driver: |
c34d610
to
b7bbdfe
Compare
bumps version to 0.5.0a1 because the `ProcessGraphVisitor` changed a bit
b7bbdfe
to
2f3aed4
Compare
@jdries can you have a quick look if it's ok to merge these PRs? |
Reviewed, the most critical question to me is whether 'namespace' is accepted by openEO partners as a new word in our terminology? We have been using it, but not sure if it was generally presented in the PSC. |
"namespace" as a concept and field is already part of the API, e.g. see the it was introduced here: Open-EO/openeo-api#305 |
Yes, that seems all fine. We don't have agreed on Open-EO/openeo-api#348 yet though. |
indeed, but that is not a blocker for this issue #183: |
thanks! |
fixes #182: adds namespace support to
DataCube.process
,PGNode
,ProcessGraphVisitor
,GraphFlattener
This improvements changes the
ProcessGraphVisitor
API changed a bit by addingnamespace
argument toenterProcess
andleaveProcess
(which will break openeo-python-driver and openeo-geopyspark-driver)Before pushing this, I wanted to go through PR+review first
(I bumped version to 0.5.0a1 to clearly mark API change)