Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

0033671: Coding - GeomTools performance update #19

Merged
merged 1 commit into from
Dec 21, 2024
Merged

0033671: Coding - GeomTools performance update #19

merged 1 commit into from
Dec 21, 2024

Conversation

dpasukhi
Copy link
Member

Update size of buffer for the brep parsing according standard

@dpasukhi dpasukhi added the 2. Enhancement New feature or request label Jun 27, 2024
@dpasukhi dpasukhi requested a review from ikochetkova June 27, 2024 10:57
@dpasukhi dpasukhi self-assigned this Jun 27, 2024
@dpasukhi
Copy link
Member Author

Issue: https://tracker.dev.opencascade.org/view.php?id=33671

ikochetkova
ikochetkova previously approved these changes Jul 5, 2024
View reviewed changes
Copy link

@ikochetkova ikochetkova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No remarks.

@dpasukhi dpasukhi marked this pull request as draft July 5, 2024 13:25
@dpasukhi
Copy link
Member Author

dpasukhi commented Jul 5, 2024

There is a regression on Windows with HLR. Needs to analyze the reason.

@dpasukhi dpasukhi deleted the branch Open-Cascade-SAS:IR July 8, 2024 15:43
@dpasukhi dpasukhi closed this Jul 8, 2024
@dpasukhi dpasukhi reopened this Jul 8, 2024
@dpasukhi dpasukhi changed the base branch from IR-1 to IR July 8, 2024 15:51
@dpasukhi dpasukhi dismissed ikochetkova’s stale review July 8, 2024 15:51

The base branch was changed.

@dpasukhi dpasukhi added the 1. Coding Coding rules, trivial changes and misprints label Jul 26, 2024
@dpasukhi dpasukhi added the 3. Tests failed Some tests result are wailed, waits for fix label Aug 27, 2024
@dpasukhi
Copy link
Member Author

The solutions looks like as a have positive impact.
Linux testing is more stable to check performance. But I would extend the buffer a little longer (26 or even 32)

GCC LINUX 
Total MEMORY difference: 96948369 / 96949356 [-0.00%]

Total CPU difference: 4282.840000000665 / 4581.440000000198 [-6.52%]


Total IMAGE difference: 13 / 14246 [0.09%]

Windows MSVC 
Total MEMORY difference: 122586547 / 122855717 [-0.22%]
Total CPU difference: 4103.625 / 3980.109375 [+3.10%]
Total IMAGE difference: 12 / 14311 [0.08%]

Windows CLANG

Total MEMORY difference: 122558458 / 122520503 [+0.03%]

Total CPU difference: 3873.15625 / 3963.34375 [-2.28%]

Total IMAGE difference: 15 / 14292 [0.10%]

@dpasukhi
Coding - GeomTools performance update #19
4bda7eb 
Update size of buffer for the brep parsing according standard
@dpasukhi dpasukhi added this to the Release 7.9 milestone Dec 21, 2024
@dpasukhi dpasukhi merged commit 4bda7eb into Open-Cascade-SAS:IR Dec 21, 2024
13 checks passed
@dpasukhi dpasukhi removed the 3. Tests failed Some tests result are wailed, waits for fix label Dec 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ikochetkova ikochetkova ikochetkova left review comments

Assignees

@dpasukhi dpasukhi

Labels
1. Coding Coding rules, trivial changes and misprints 2. Enhancement New feature or request
Projects
Maintenance
Status: Done
Milestone
Release 7.9
Development

Successfully merging this pull request may close these issues.
2 participants
@dpasukhi @ikochetkova