CR167: GLTF Import - Metadata support #184
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AtheneNoctuaPt
added
2. Enhancement
dpasukhi
requested changes
Dec 10, 2024
| @@ -297,17 +297,19 @@ protected: | |||
| void bindNodeShape (TopoDS_Shape& theShape, | |||
| const TopLoc_Location& theLoc, | |||
| const TCollection_AsciiString& theNodeId, | |||
| const RWGltf_JsonValue* theUserName) | |||
| const RWGltf_JsonValue* theUserName, | |||
There was a problem hiding this comment.
I would suggest to use const Handle(TDataStd_NamedData)&.
Originally input parameter must be not updated. It is originally a part of the new internal class.
The same for 2 more new methods in current file
|
|
||
| //! Parses the "extras" value provided in the constructor. | ||
| //! @return Container with parsed data. May be nullptr if failed to parse. | ||
| Handle(TDataStd_NamedData) Parse(); |
There was a problem hiding this comment.
But the myResult allocated always. It is not related?
Can be it null? Or better to avoid allocate ahead?
tests/metadata/gltf/end
Outdated
| # Compare metadata in files. | ||
| set aMetaDataLines [split ${aMetaData} "\n"] | ||
| set aRefMetaDataLines [split ${ref_metadata} "\n"] | ||
| set aMetaDataLinesCount [llength $aMetaDataLines] |
There was a problem hiding this comment.
Please clear up the short tabs from here.
Imposters here :)
Limited support of metadata import is added to RWGltf_GltfJsonParser. Following Json data types are currently supported: int32, double, string, array of int32, array of double, array of strings, Json object. Notable unsupported types are: binary data, array of Json objects. Metadata is processed for nodes and meshes. Tests "gltf_export" are updated with import testing and renamed to "gltf". Method RWGltf_GltfJsonParser::gltfParseSceneNode() is slightly refactored: parsing of transformations and transformation matrices is moved into separate functions.
AtheneNoctuaPt
force-pushed
the
CR167
branch
from
141bd0a to
bbbb8ea
Compare
dpasukhi
approved these changes
Dec 10, 2024
dpasukhi
added a commit
to dpasukhi/OCCT
that referenced
this pull request
Dec 14, 2024
Regression after Open-Cascade-SAS#184 where some methods are not isolated.
dpasukhi
added a commit
to dpasukhi/OCCT
that referenced
this pull request
Dec 14, 2024
Regression after Open-Cascade-SAS#184 where some methods are not isolated.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Limited support of metadata import is added to RWGltf_GltfJsonParser. Following Json data types are currently supported: int32, double, string, array of int32, array of double, array of strings, Json object. Notable unsupported types are: binary data, array of Json objects. Metadata is processed for nodes and meshes.
Tests "gltf_export" are updated with import testing and renamed to "gltf".
Method RWGltf_GltfJsonParser::gltfParseSceneNode() is slightly refactored: parsing of transformations and transformation matrices is moved into separate functions.