Make BGS and Giant's Knife Advancement Items for Logic Consideration

[shirosoluna]

Currently tricks that require BGS or Knife (such as adult_dot_skip) would not be able to be used as a logical option with BGS and Knife as False in the advancement item table. While this does not mean there are unbeatable seeds, it just defaults to the glitchless option of finding items to open the door rather than skipping it.

This also will address when enemy drops move to main as they are currently considered as True on realrob's branch and both swords may be required.

Testing

will be running a few plando checks to verify if it can select a sword for skipping the door. But this is a manual verification

[dotzo]

Tested positive with a basic plando to start as adult with closed door and 1 trifoce piece in child, and locking all items to open the door or skip it into child only checks. Seeds fail to generate when the sword is not labelled as advancement. Successfully generate when it is.

[r0bd0g]

When I tested this last year, I did it by adding bgs as a requirement to Ganon, and it would fail to generate.

[r0bd0g]

There's a check for BGS in the major item count hint code that manually adds it to the count of major items in an area, since it was previously not an advancement item. I think this code can be removed if BGS is advancement now, and it could be confusing for somebody later if this isn't removed now. So I think remove line 1172 in hints.py. (When I did this for enemy drops I also had to adjust the foolish hint exception for BGS, to make it unable to be foolish under enemy drops, but this won't be required for you since it's already got an exception for glitched logic.)

[r0bd0g]

(I think this also makes DD that last major item not marked as advancement. It might make sense to just be rid of this category of item right here and mark it as advancement too.)

[flagrama]

The new trick should probably be part of a separate PR.

[shirosoluna]

The new trick should probably be part of a separate PR.

@fenhl

I dont want to create a new branch just to submit maintenance tricks for advanced a separate PR. This has no impact to glitchless logic. It's an advanced only trick.
I'll fix the syntax error tho just noticed the typo.

Has there been discussion on the original PR for advancement items? This is currently a bug for advanced
So both topics are maintenance and imo can be put together. Tricks are really minor.

[fenhl]

They're still separate concerns, so they should be in separate PRs.

I'm not aware of any discussion regarding the original PR, not that that would be necessary — only a code review, which should be quick since it's a small PR.

[r0bd0g]

I mentioned that there was code that manually adds BGS to the major item hint count that would be redundant if it's a major item, so that code should be removed. It's line 1164 of Hints.py.

[shirosoluna]

I mentioned that there was code that manually adds BGS to the major item hint count that would be redundant if it's a major item, so that code should be removed. It's line 1164 of Hints.py.

fixed