Give Maps and Compasses separate shuffle settings #2458
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merge dev
…vidual shuffle settings.
…of other dungeon items.
fenhl
requested changes
Sep 16, 2025
Collaborator
fenhl
left a comment
fenhl
left a comment
There was a problem hiding this comment.
Some code style nits and one minor logic bug that doesn't actually break anything, looks good other than that.
fenhl
added
Type: Enhancement
Author
|
Changes made, thank you for looking at that! |
fenhl
approved these changes
Sep 16, 2025
fenhl
added
Status: Waiting for Release
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements #954. Think the changes are mostly straightforward and the settings have just been broken out into two separate Comboboxes.
