forked from AmazingAmpharos/OoT-Randomizer
-
Notifications
You must be signed in to change notification settings - Fork 243
Maps and Compasses give Dungeon and Boss locations #2453
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
GSKirox
wants to merge
11
commits into
OoTRandomizer:Dev
Choose a base branch
from
GSKirox:dungeon_boss_info
base: Dev
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jdunn596
reviewed
Sep 14, 2025
db3a174 to
b21d07d
Compare
fenhl
reviewed
Sep 21, 2025
3e9cb56 to
204ff5b
Compare
Collaborator
|
Sorry for the notification spam, I keep forgetting why this is labelled waiting for author: Boss location info is going to be moved to compasses, see conversation starting at https://discord.com/channels/274180765816848384/438697911753113600/1419704545478705343 for context. |
204ff5b to
135743f
Compare
135743f to
5003e5c
Compare
5003e5c to
d31a289
Compare
f2a81a3 to
c18e8f3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Component: ASM/C
Changes some internals of the ASM/C libraries
Component: Hints
related to how we help the player
Component: Patching
Affects the patching of the ROM
Component: Setting
specific to setting(s)
Status: Needs Review
Someone should be looking at it
Type: Enhancement
New feature or request
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solves #1219.
This PR enhances the existing toggle "Maps and Compasses give information" to a multiselect with four different options.

First and last have the same effect as the old toggle, but can be now applied independently.
The other two add new features for the maps and compasses : dungeon location in dungeon shuffle, and boss location in boss shuffle.
This information is given :
These menus will fill as the maps and compasses are found (or be already full if maps are given at the start), except for the dungeons without them which just put the information right away.
The map menu also list the boss information for convenience, but only if both map and compass for the respective dungeon have been found.
Additional notes :
There is some commented code in Patches.py that is intended to handle it, but it doesn't work for decoupled, and it will need shorter names for all Hintarea.