Skip to content

Conversation

@GSKirox
Copy link
Collaborator

@GSKirox GSKirox commented Sep 9, 2025

Solves #1219.

This PR enhances the existing toggle "Maps and Compasses give information" to a multiselect with four different options.
image

First and last have the same effect as the old toggle, but can be now applied independently.

The other two add new features for the maps and compasses : dungeon location in dungeon shuffle, and boss location in boss shuffle.
This information is given :

  • When you find the corresponding map/dungeon of the dungeon, in the textbox
image image
  • In two new menus in pause on the map screen if you press Dpad left for the entrances and Dpad right for the bosses
image image

These menus will fill as the maps and compasses are found (or be already full if maps are given at the start), except for the dungeons without them which just put the information right away.
The map menu also list the boss information for convenience, but only if both map and compass for the respective dungeon have been found.

Additional notes :

  • I had to bump up RANDO_OVERLAY_DB_SIZE in gfx a bit to make this fit, even with the shorter names.
  • The function update_map_compass_messages is atrocious to read. I'm sorry. The saving grace is that i moved this code to Messages.py instead of adding even more to Patches.py.
  • The C menu should be compatible with mixed pools. In this case, the two menus will list instead the areas where every dungeon/boss are.
    There is some commented code in Patches.py that is intended to handle it, but it doesn't work for decoupled, and it will need shorter names for all Hintarea.

@GSKirox GSKirox added Type: Enhancement New feature or request Component: ASM/C Changes some internals of the ASM/C libraries Status: Needs Review Someone should be looking at it Component: Setting specific to setting(s) Component: Hints related to how we help the player Component: Patching Affects the patching of the ROM labels Sep 9, 2025
@fenhl fenhl self-requested a review September 9, 2025 12:03
@fenhl fenhl linked an issue Sep 9, 2025 that may be closed by this pull request
@GSKirox GSKirox force-pushed the dungeon_boss_info branch 3 times, most recently from db3a174 to b21d07d Compare September 15, 2025 09:24
@fenhl fenhl added the Status: Waiting for Author Changes or response requested label Sep 21, 2025
@GSKirox GSKirox force-pushed the dungeon_boss_info branch 2 times, most recently from 3e9cb56 to 204ff5b Compare September 22, 2025 06:27
@fenhl fenhl added Status: Waiting for Author Changes or response requested and removed Status: Waiting for Author Changes or response requested labels Sep 22, 2025
@fenhl fenhl removed the Status: Waiting for Author Changes or response requested label Oct 4, 2025
@fenhl
Copy link
Collaborator

fenhl commented Oct 4, 2025

Sorry for the notification spam, I keep forgetting why this is labelled waiting for author: Boss location info is going to be moved to compasses, see conversation starting at https://discord.com/channels/274180765816848384/438697911753113600/1419704545478705343 for context.

@fenhl fenhl added the Status: Waiting for Author Changes or response requested label Oct 4, 2025
@GSKirox GSKirox force-pushed the dungeon_boss_info branch from 204ff5b to 135743f Compare October 5, 2025 07:41
@GSKirox GSKirox changed the title Maps give Dungeon and Boss locations Maps and Compasses give Dungeon and Boss locations Oct 5, 2025
@GSKirox GSKirox force-pushed the dungeon_boss_info branch from 135743f to 5003e5c Compare October 5, 2025 07:56
@fenhl fenhl removed the Status: Waiting for Author Changes or response requested label Oct 5, 2025
@GSKirox GSKirox force-pushed the dungeon_boss_info branch from 5003e5c to d31a289 Compare October 5, 2025 08:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Component: ASM/C Changes some internals of the ASM/C libraries Component: Hints related to how we help the player Component: Patching Affects the patching of the ROM Component: Setting specific to setting(s) Status: Needs Review Someone should be looking at it Type: Enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Dungeon Maps Show Dungeon Location

3 participants