Generate fewer refill special deals above market price #2418
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a new check when placing items where if the item is placed in a special deal location and that location's price is at or above the item's market price, the price is rerolled once and the lower of the two values is used.
The idea is to counterbalance the limited usefulness of refill special deals (due to being one-time purchases), and to help reduce rupee farming a bit. It's done on a random basis rather than always picking a price below market for the following reasons:
The “market price” of an item is defined as follows:
Closes #1987.
Testing
This has not yet been tested. A good way to test this might be to useSee #2418 (comment).ootrstatsto categorize item prices and compare the price distributions on Dev and this branch.