Skip to content

Conversation

@druristmcdwarf
Copy link

  • Moved Kaepora Gaebora from bgm_sequence_ids to fanfare_sequence_ids.

@fenhl fenhl linked an issue Apr 5, 2025 that may be closed by this pull request
@fenhl fenhl added Type: Bug Something isn't working Status: Needs Testing Probably should be tested Component: Cosmetics Affects the patching of cosmetics labels Apr 5, 2025
@flagrama
Copy link

flagrama commented Apr 5, 2025

Testing when this song replaces several fanfares it works properly is probably what needs tested the most. Several times in the past songs having a different length than expected have caused issues (e.g. mini games not ending when they are supposed) so some additional changes may be needed.

This is also just a quick and dirty fix to an issue where music seems to "randomly" stop sometimes. There's also a potentially more proper fix where we remove the fanfare flag from the Kaepora Gaebora sequence since people are used to having it as a BGM. Depending on if there is a problem or not doing this quick fix it might be easier to fix it for real by doing that. If this PR works without issues placing the sequence on other fanfares, it solves a current problem so is good to merge, though you could still look into "doing it right" if you're interested. If this quick fix works well and gets merged I'll create a new issue so the above potentially better fix doesn't get forgotten.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Component: Cosmetics Affects the patching of cosmetics Status: Needs Testing Probably should be tested Type: Bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Kaepora Gaepora sequence should be a fanfare

3 participants