-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add 8 new models and updates #286
base: master
Are you sure you want to change the base?
Conversation
models/alkhalaf2024/metadata.yaml
Outdated
context: | ||
- research | ||
source: | ||
- https://tinyurl.com/5n8c7k8t |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should not use a GoogleDrive link with some images as the source. It should, instead, be the paper which includes these figures.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done.
source substituted to https://dx.doi.org/10.5220/0000178400003598
landingPage removed.
models/alkhalaf2024/metadata.yaml
Outdated
representationStyle: | ||
- ontouml | ||
landingPage: | ||
- https://hdl.handle.net/11311/1256092 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The landing page field should not point to a paper. The source field should be used for that.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done.
source substituted to https://dx.doi.org/10.5220/0000178400003598
landingPage removed.
context: | ||
- research | ||
source: | ||
- https://raw.githubusercontent.com/pedropaulofb/resiliont/main/resources/Ontological%20Foundations%20of%20Resilience.pdf |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Replace this link with the DOI of the paper.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is no DOI yet. We can update the field once we have this piece of data.
representationStyle: | ||
- ontouml | ||
landingPage: | ||
- https://catalogue.eucaim.cancerimage.eu/#/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This does not seem to be the landing page of the ontology.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
URL removed.
context: | ||
- research | ||
source: | ||
- https://link.springer.com/chapter/10.1007/978-3-031-47262-6_19 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Use the DOI instead.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done.
models/pinheiro2024api/metadata.yaml
Outdated
- enterprise architecture | ||
- enterprise architecture management | ||
- mining | ||
- ontology |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ontology as a keyword is pointless.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
keyword removed.
models/pinheiro2024api/metadata.yaml
Outdated
context: | ||
- research | ||
source: | ||
- https://link.springer.com/chapter/10.1007/978-3-031-64755-0_13 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Use the paper's DOI instead.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done.
representationStyle: | ||
- ontouml | ||
landingPage: | ||
- https://essay.utwente.nl/101204/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is not a landing page. Please remove.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
URL substituted by another that contains complementary information about the ontology.
context: | ||
- research | ||
source: | ||
- http://essay.utwente.nl/101204/1/Sariev_BA_EEMCS.pdf |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You should use the permanent url provided by the UT: https://purl.utwente.nl/essays/101204
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done.
representationStyle: | ||
- ontouml | ||
landingPage: | ||
- https://link.springer.com/article/10.1007/s10270-023-01146-w |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is not a landing page for the ontology.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
URL removed from landingPage. The paper does not mention a landingPage to the ontology.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please see my comments on the files.
@tgoprince, thank you for the review. All recommended adjustments have been made. Can you please review the PR again? The modifications made were basically:
|
…into resiliont
@tgoprince , I fixed the mgic2011 dataset, which had non-OntoUML models. You can review it now. |
Eight new models added. All models were sent via the catalog's Google Forms after we got in contact with the authors.
Model updated:
All
ttl
files with the outdatedpurl.org
Catalog URIs have been updated to the latestw3id.org
URI.