Fix MakeFullUnicode and add more unicode columns. #886
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Important notes:
MakeFullUnicode
here. I don't think theALTER TABLE ... DEFAULT CHARACTER SET
is strictly needed if the goal is simply to pinpoint a single column. Conversely, if you want to update every column in the table, you could drop thecolumnname
argument, run theALTER TABLE ... CONVERT TO CHARACTER SET
command to set both charset and collation, and skip the column-specific query. This would automatically apply to all character columns in the table.Fixes #885