Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/ogc 1701 delete resource including future reserverations #1417

Conversation

Tschuppi81
Copy link
Contributor

@Tschuppi81 Tschuppi81 commented Jun 28, 2024

Resource: Allow deleting resources with future reservations

Deletes related payments

TYPE: Feature
LINK: ogc-1701

Checklist

  • I have performed a self-review of my code
  • I considered adding a reviewer
  • I have updated the PO files
  • I made changes/features for both org and town6
  • I have tested my code thoroughly by hand
  • I have added tests for my changes/features

Copy link

linear bot commented Jun 28, 2024

Copy link

codecov bot commented Jun 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.96%. Comparing base (d5fc407) to head (0500aca).
Report is 14 commits behind head on master.

Additional details and impacted files
Files Coverage Δ
src/onegov/activity/models/activity.py 98.90% <100.00%> (ø)
src/onegov/directory/models/directory_entry.py 95.23% <100.00%> (ø)
src/onegov/gazette/models/notice.py 97.90% <100.00%> (ø)
src/onegov/notice/models.py 100.00% <100.00%> (ø)
src/onegov/org/layout.py 91.21% <ø> (ø)
src/onegov/org/views/resource.py 79.60% <100.00%> (+0.35%) ⬆️
src/onegov/ticket/model.py 82.85% <100.00%> (ø)

... and 2 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d5fc407...0500aca. Read the comment docs.

@Tschuppi81 Tschuppi81 requested a review from Daverball July 2, 2024 06:33
src/onegov/org/views/resource.py Outdated Show resolved Hide resolved
src/onegov/org/views/resource.py Show resolved Hide resolved
@Tschuppi81 Tschuppi81 marked this pull request as ready for review July 2, 2024 07:37
@Tschuppi81 Tschuppi81 merged commit b4a9b75 into master Jul 8, 2024
14 checks passed
@Tschuppi81 Tschuppi81 deleted the feature/ogc-1701-delete-resource-including-future-reserverations branch July 8, 2024 08:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants