Ogc 1493 react mode #1229
Open
Ogc 1493 react mode #1229
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The minified .js are for production
|
I would have updated it to the newest version too, but I couldn't figure out how to get the react.js files for the newer versions. But now react is at least not in the developer-mode anymore. |
msom
approved these changes
Mar 12, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files
... and 4 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
create-react-class is a wrapper for the legacy React.createClass API. Using create-react-class, we can continue to use the deprecated way of creating React components - otherwise, we have to upgrade each component manually, a time and error-prone process. For now, we can use latest React without changing our components. However, we should update a component whenever we work on it to the latest format.
react-transition-group was moved away from React into a community-maintained project.
Calling foundation() on a React-rendered element caused all handlers to quit working (i.e., onChange did never receive a callback). Wrapping the reveal element in a dedicated element and keeping the react-rendered part separate seems to work.
Conflicts: src/onegov/swissvotes/assets/js/react-dom.min.js tests/onegov/form/assets/react-dom.min.js tests/onegov/form/conftest.py
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please fill in the commit message below and work through the checklist. You can delete parts that are not needed, e.g. the optional description, the link to a ticket or irrelevant options of the checklist.
Commit message
Core: Change react-mode to production, not developer
TYPE: Bugfix
LINK: OGC-1493