-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/ogc 1408 videos in directories #1157
Conversation
src/onegov/form/display.py
Outdated
url = None | ||
data = self.escape(field.data) | ||
|
||
if kwargs: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Daverball I did not find a good way to distinguish between editing and displaying the video url.
My goal is to show the 'plain url' in a StringField
when editing the directory entry and the embedded video otherwise.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Field display is strictly for display, it should never be editable, so it does not make sense to render an input field here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You'll want to create a separate Widget for rendering the input, but considering the widget is just a regular url field anyways, you don't need a custom widget.
Codecov ReportAttention:
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #1157 +/- ##
=======================================
Coverage 87.61% 87.62%
=======================================
Files 1188 1188
Lines 79454 79500 +46
=======================================
+ Hits 69616 69660 +44
- Misses 9838 9840 +2 ☔ View full report in Codecov by Sentry. |
Use markup directly Co-authored-by: David Salvisberg <[email protected]>
Make use of the original widget Co-authored-by: David Salvisberg <[email protected]>
fix multi-line import Co-authored-by: David Salvisberg <[email protected]>
This reverts commit 14d6753.
Co-authored-by: David Salvisberg <[email protected]>
…ape on any parameter of the format method. Co-authored-by: David Salvisberg <[email protected]>
Directories: Adds support for videos
TYPE: Feature
LINK: ogc-1408