Add tests

src/onegov/pas/forms/attendence.py

@@ -210,8 +210,6 @@ class AttendenceAddCommissionForm(Form, SettlementRunBoundMixin):
         validators=[InputRequired()],
     )
 
-    # todo:
-
     def get_useful_data(self) -> dict[str, 'Any']:  # type:ignore[override]
         result = super().get_useful_data()
         result['commission_id'] = self.model.id

src/onegov/pas/forms/parliamentarian.py

@@ -1,6 +1,8 @@
+from onegov.form.fields import PhoneNumberField
 from onegov.form.fields import TranslatedSelectField
 from onegov.form.fields import UploadField
 from onegov.form.forms import NamedFileForm
+from onegov.form.validators import ValidPhoneNumber
 from onegov.pas import _
 from onegov.pas.models.parliamentarian import GENDERS
 from onegov.pas.models.parliamentarian import SHIPPING_METHODS
@@ -150,22 +152,25 @@ class ParliamentarianForm(NamedFileForm):
         fieldset=_('Additional information'),
     )
 
-    # todo: phone number field and validator?
-    phone_private = StringField(
+    phone_private = PhoneNumberField(
         label=_('Private phone number'),
         fieldset=_('Additional information'),
+        validators=[ValidPhoneNumber()],
+        render_kw={'autocomplete': 'tel'}
     )
 
-    # todo: phone number field and validator?
-    phone_mobile = StringField(
+    phone_mobile = PhoneNumberField(
         label=_('Mobile phone number'),
         fieldset=_('Additional information'),
+        validators=[ValidPhoneNumber()],
+        render_kw={'autocomplete': 'tel'}
     )
 
-    # todo: phone number field and validator?
-    phone_business = StringField(
+    phone_business = PhoneNumberField(
         label=_('Business phone number'),
         fieldset=_('Additional information'),
+        validators=[ValidPhoneNumber()],
+        render_kw={'autocomplete': 'tel'}
     )
 
     email_primary = EmailField(

src/onegov/pas/forms/parliamentarian_role.py

@@ -62,7 +62,7 @@ class ParliamentarianRoleForm(Form):
     parliamentary_group_role = TranslatedSelectField(
         label=_('Parliamentary group role'),
         choices=list(PARLIAMENTARY_GROUP_ROLES.items()),
-        default='noe'
+        default='none'
     )
 
     def on_request(self) -> None:

src/onegov/pas/forms/rate_set.py

@@ -225,9 +225,11 @@ class RateSetForm(Form):
     )
 
     def validate_year(self, field: IntegerField) -> None:
-        if field.data is not None and not isinstance(self.model, RateSet):
+        if field.data is not None:
             query = self.request.session.query(RateSet)
-            query = query.filter_by(year=field.data)
+            query = query.filter(RateSet.year == field.data)
+            if isinstance(self.model, RateSet):
+                query = query.filter(RateSet.id != self.model.id)
             if query.first():
                 raise ValidationError(_(
                     'Rate set for ${year} alredy exists',

src/onegov/pas/layouts/commission.py

@@ -22,6 +22,7 @@ def og_description(self) -> str:
     def breadcrumbs(self) -> list[Link]:
         return [
             Link(_('Homepage'), self.homepage_url),
+            Link(_('PAS settings'), self.pas_settings_url),
             Link(self.title, self.request.link(self.model))
         ]
 
@@ -61,6 +62,7 @@ def og_description(self) -> str:
     def breadcrumbs(self) -> list[Link]:
         return [
             Link(_('Homepage'), self.homepage_url),
+            Link(_('PAS settings'), self.pas_settings_url),
             Link(
                 _('Commissions'),
                 self.request.link(self.collection)

src/onegov/pas/layouts/commission_membership.py

@@ -25,6 +25,7 @@ def commission_collection(self) -> CommissionCollection:
     def breadcrumbs(self) -> list[Link]:
         return [
             Link(_('Homepage'), self.homepage_url),
+            Link(_('PAS settings'), self.pas_settings_url),
             Link(
                 _('Commissions'),
                 self.request.link(self.commission_collection)

src/onegov/pas/layouts/default.py

@@ -10,7 +10,7 @@ def pas_settings_url(self) -> str:
         return self.request.link(self.app.org, 'pas-settings')
 
     def format_minutes(self, value: int | None) -> str:
-        if not value:
+        if not value or value < 0:
             return ''
 
         hours = value // 60

src/onegov/pas/layouts/parliamentarian.py

@@ -22,6 +22,7 @@ def og_description(self) -> str:
     def breadcrumbs(self) -> list[Link]:
         return [
             Link(_('Homepage'), self.homepage_url),
+            Link(_('PAS settings'), self.pas_settings_url),
             Link(self.title, self.request.link(self.model))
         ]
 
@@ -61,6 +62,7 @@ def og_description(self) -> str:
     def breadcrumbs(self) -> list[Link]:
         return [
             Link(_('Homepage'), self.homepage_url),
+            Link(_('PAS settings'), self.pas_settings_url),
             Link(
                 _('Parliamentarians'),
                 self.request.link(self.collection)

src/onegov/pas/layouts/parliamentarian_role.py

@@ -25,6 +25,7 @@ def parliamentarian_collection(self) -> ParliamentarianCollection:
     def breadcrumbs(self) -> list[Link]:
         return [
             Link(_('Homepage'), self.homepage_url),
+            Link(_('PAS settings'), self.pas_settings_url),
             Link(
                 _('Parliamentarians'),
                 self.request.link(self.parliamentarian_collection)

src/onegov/pas/layouts/settlement_run.py

@@ -22,6 +22,7 @@ def og_description(self) -> str:
     def breadcrumbs(self) -> list[Link]:
         return [
             Link(_('Homepage'), self.homepage_url),
+            Link(_('PAS settings'), self.pas_settings_url),
             Link(self.title, self.request.link(self.model))
         ]
 
@@ -61,6 +62,7 @@ def og_description(self) -> str:
     def breadcrumbs(self) -> list[Link]:
         return [
             Link(_('Homepage'), self.homepage_url),
+            Link(_('PAS settings'), self.pas_settings_url),
             Link(
                 _('Settlement runs'),
                 self.request.link(self.collection)

src/onegov/pas/models/parliamentarian.py

@@ -293,10 +293,8 @@ def shipping_method_label(self) -> str:
 
     @property
     def active(self) -> bool:
-        # todo: add hybrid property?
         if not self.roles:
             return True
-
         for role in self.roles:
             if role.end is None or role.end >= date.today():
                 return True