Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve docs #174

Open
wants to merge 30 commits into
base: master
Choose a base branch
from
Open

Improve docs #174

wants to merge 30 commits into from

Conversation

KTibow
Copy link

@KTibow KTibow commented Mar 15, 2020

The docs don't include everything that's in the code, and after some poking around in the source code and with autocomplete I found some undocumented stuff that could be pretty helpful.

@msftclas
Copy link

msftclas commented Mar 15, 2020

CLA assistant check
All CLA requirements met.

@KTibow KTibow changed the title Add docs Improve docs Mar 16, 2020
@KTibow
Copy link
Author

KTibow commented Mar 16, 2020

Fixes #174 and fixes #148

@KTibow
Copy link
Author

KTibow commented Mar 16, 2020

Fixes #149

@KTibow
Copy link
Author

KTibow commented Mar 16, 2020

My fear is that @D4N14L, @wiktorn, and @mimisasouvanh have completely abandoned this OneDrive repository. Can you guys please come back? It's so out of date people even made a fork. I ❤️ all the work you did.

@wiktorn
Copy link
Contributor

wiktorn commented Mar 19, 2020

@KTibow I indeed made a largish contribution some time ago but I never was a maintainer/owner of this repo, so I can't help you on that.

@KTibow
Copy link
Author

KTibow commented Mar 19, 2020

@wiktorn got it. Do you know where I can find other people though? I got mine from https://github.com/OneDrive/onedrive-sdk-python/graphs/contributors.
cdmayer hasn't been active on GitHub since November, 2016. D4N14L hasn't been active since March 12th, and has previously been off GitHub for half of a year.
At this point all of the people other than you are mimisasouvanh, ybizeul, and the rest only have done 1 commit.

@wiktorn
Copy link
Contributor

wiktorn commented Mar 19, 2020

I have no clue. Maybe it's time for community managed fork, looks like Microsoft has abandoned this repo.

@KTibow
Copy link
Author

KTibow commented Mar 19, 2020

Do you think it would be a good idea to put the same PR to onedrivesdk-fork?

@wiktorn
Copy link
Contributor

wiktorn commented Mar 19, 2020

It might be good idea. Not sure, if they haven't moved on to AtakamaLLC/cloudsync-onedrive

@KTibow
Copy link
Author

KTibow commented Mar 19, 2020

Hmm, it says that it conforms to the AtakamaLLC/cloudsync docs which I don't see. What does AtakamaLLC/cloudsync do? Syncing a folder or something?

@wiktorn
Copy link
Contributor

wiktorn commented Mar 19, 2020

You need to ask there

Merge the fork's changes so a PR can be created
@mimisasouvanh
Copy link
Contributor

Let me investigate who can own this PR.

@KTibow
Copy link
Author

KTibow commented May 4, 2020

@mimisasouvanh Ooops... didn't mean to violate the CLA... I need to change some stuff.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants