-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MailChimp Replacement #2595
base: development
Are you sure you want to change the base?
MailChimp Replacement #2595
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello @angelalalacheng
I have noticed a small needed fix in the code, when a user is inputting nothing, and , when clicked weekly on the button "Broadcast Weekly update " and is still working without an error popup message.
Screen.Recording.2024-08-22.at.9.25.25.AM.mov
Thank you.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
✅ Deploy Preview for highestgoodnetwork-dev ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
@manikittu810 Thank you for your review. I added the error popup message when a user is inputting nothing. It is helpful if you can try again. |
Hi, @panchalvatneu |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello @angelalalacheng
Functions are not working as mentioned.
Screen.Recording.2024-09-27.at.4.01.39.PM.mov
Thank you.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code works great, all functionalities worked as described. It is worth noting that I added my own TinyMCE editor API code that was reverted in #2232 (specifically, this line caused the editor to not load since we don't bundle it anymore as it was required for this open-source GPL version of the library).
Description
ORIGINAL REQUEST
Related PRS (if any):
This frontend PR is related to the #1080 backend PR.
Main changes explained:
src/components/Announcements/index.jsx
for image upload plugins and remove useless functions.How to test:
npm install
andnpm run start:local
to run this PR locallyBroadcast Weekly Update
andSend Email to specific user
and remember to test sending the email with image.Screenshots or videos of changes:
https://www.loom.com/share/1f66a2dd69fa4be4921370bae2a4c69b?sid=bf0393aa-cd39-44ba-ab9b-c37f6ddaf033
Note:
If your account want to receive email, you need to set the email subscription in the profile page.
Google also only allows limited sending, so we need this to send in batches of less than 100 (so 90) at a time and timed so that we don’t get blocked as spam.