Skip to content

Commit

Permalink
Merge pull request #23 from One-armed-boy/revert-22-test/webMvc
Browse files Browse the repository at this point in the history
Revert "Controller 레이어 테스트를 위한 mockMvc 테스트 도입"
  • Loading branch information
One-armed-boy authored Feb 27, 2024
2 parents 01e65b1 + 3573689 commit 3118401
Show file tree
Hide file tree
Showing 27 changed files with 150 additions and 723 deletions.
6 changes: 1 addition & 5 deletions src/main/java/com/stream/configuration/SecurityConfig.java
Original file line number Diff line number Diff line change
Expand Up @@ -10,18 +10,15 @@
import org.springframework.security.web.authentication.www.BasicAuthenticationFilter;

import com.stream.domain.role.RolesEnum;
import com.stream.security.jwt.JwtAuthFailFilter;
import com.stream.security.jwt.JwtAuthenticationFilter;

@Configuration
public class SecurityConfig {
private final JwtAuthenticationFilter jwtAuthenticationFilter;
private final JwtAuthFailFilter jwtAuthFailFilter;

@Autowired
public SecurityConfig(JwtAuthenticationFilter jwtAuthenticationFilter, JwtAuthFailFilter jwtAuthFailFilter) {
public SecurityConfig(JwtAuthenticationFilter jwtAuthenticationFilter) {
this.jwtAuthenticationFilter = jwtAuthenticationFilter;
this.jwtAuthFailFilter = jwtAuthFailFilter;
}

@Bean
Expand All @@ -35,7 +32,6 @@ public SecurityFilterChain filterChain(HttpSecurity http) throws Exception {
http.csrf(csrf -> csrf.disable())
.httpBasic(c -> c.disable())
.addFilterAfter(jwtAuthenticationFilter, BasicAuthenticationFilter.class)
.addFilterBefore(jwtAuthFailFilter, JwtAuthenticationFilter.class)
.authorizeHttpRequests(c -> {
c.requestMatchers("/login", "/sign-up").permitAll()
.anyRequest()
Expand Down
39 changes: 37 additions & 2 deletions src/main/java/com/stream/controller/LoginController.java
Original file line number Diff line number Diff line change
Expand Up @@ -10,13 +10,17 @@
import org.springframework.web.bind.annotation.RequestBody;
import org.springframework.web.bind.annotation.RestController;

import com.stream.controller.dto.login.LoginRequest;
import com.stream.controller.dto.login.LoginResponse;
import com.stream.domain.member.dto.login.LoginCommand;
import com.stream.domain.member.dto.login.LoginResult;
import com.stream.facade.LoginFacade;
import com.stream.security.jwt.JwtMetadata;

import jakarta.validation.Valid;
import jakarta.validation.constraints.Email;
import jakarta.validation.constraints.NotNull;
import lombok.Builder;
import lombok.Getter;
import lombok.ToString;
import lombok.extern.slf4j.Slf4j;

@Slf4j
Expand Down Expand Up @@ -48,4 +52,35 @@ private ResponseCookie createCookie(LoginResult result) {
Duration.ofMillis(result.getAccessTokenExpireMs()))
.build();
}

@Getter
@ToString
public static class LoginRequest {
@NotNull(message = "이메일을 입력해주세요.")
@Email(message = "유효한 이메일을 입력해주세요.")
private String email;

@NotNull(message = "비밀번호를 입력해주세요.")
private String inputPassword;

@Builder
public LoginRequest(String email, String inputPassword) {
this.email = email;
this.inputPassword = inputPassword;
}

public LoginCommand toCommand() {
return LoginCommand.builder().email(email).inputPassword(inputPassword).build();
}
}

@Getter
@ToString
public static class LoginResponse {
private String accessToken;

public LoginResponse(String accessToken) {
this.accessToken = accessToken;
}
}
}
42 changes: 40 additions & 2 deletions src/main/java/com/stream/controller/SignupController.java
Original file line number Diff line number Diff line change
@@ -1,17 +1,23 @@
package com.stream.controller;

import java.util.Date;

import org.springframework.beans.factory.annotation.Autowired;
import org.springframework.http.ResponseEntity;
import org.springframework.web.bind.annotation.PostMapping;
import org.springframework.web.bind.annotation.RequestBody;
import org.springframework.web.bind.annotation.RestController;

import com.stream.controller.dto.signup.SignupRequest;
import com.stream.controller.dto.signup.SignupResponse;
import com.stream.domain.member.dto.signup.SignupCommand;
import com.stream.domain.member.dto.signup.SignupResult;
import com.stream.facade.SignupFacade;

import jakarta.validation.Valid;
import jakarta.validation.constraints.Email;
import jakarta.validation.constraints.NotNull;
import lombok.Builder;
import lombok.Getter;
import lombok.ToString;
import lombok.extern.slf4j.Slf4j;

@Slf4j
Expand All @@ -32,4 +38,36 @@ public ResponseEntity<SignupResponse> signup(@Valid @RequestBody final SignupReq

return ResponseEntity.ok().body(new SignupResponse(result.getEmail(), result.getSignupDate()));
}

@Getter
@ToString
public static class SignupRequest {
@NotNull(message = "이메일을 입력해주세요.")
@Email(message = "유효한 이메일을 입력해주세요.")
private String email;

@NotNull(message = "비밀번호를 입력해주세요.")
private String inputPassword;

@Builder
public SignupRequest(String email, String inputPassword) {
this.email = email;
this.inputPassword = inputPassword;
}

public SignupCommand toCommand() {
return SignupCommand.builder().email(email).password(inputPassword).build();
}
}

public static class SignupResponse {
private String email;
private Date signupDate;

public SignupResponse(String email, Date signupDate) {
this.email = email;
this.signupDate = signupDate;
}
}

}
18 changes: 8 additions & 10 deletions src/main/java/com/stream/controller/VideoController.java
Original file line number Diff line number Diff line change
@@ -1,14 +1,15 @@
package com.stream.controller;

import java.util.List;

import org.springframework.beans.factory.annotation.Autowired;
import org.springframework.http.ResponseEntity;
import org.springframework.web.bind.annotation.GetMapping;
import org.springframework.web.bind.annotation.RequestParam;
import org.springframework.web.bind.annotation.RestController;

import com.stream.controller.dto.video.GetVideoResponse;
import com.stream.controller.dto.video.ListVideoResponse;
import com.stream.domain.video.VideoService;
import com.stream.domain.video.dto.VideoDto;

@RestController
public class VideoController {
Expand All @@ -20,17 +21,14 @@ public VideoController(VideoService videoService) {
}

@GetMapping(path = "/videos")
public ResponseEntity<ListVideoResponse> listVideo() {
return ResponseEntity.ok()
.body(ListVideoResponse.builder()
.videos(videoService.listVideo())
.build());
public ResponseEntity<List<VideoDto>> listVideo() {
List<VideoDto> videoDtoList = videoService.listVideo();
return ResponseEntity.ok().body(videoDtoList);
}

@GetMapping(path = "/videos", params = "id")
public ResponseEntity<GetVideoResponse> getVideo(@RequestParam long id) {
return ResponseEntity.ok()
.body(GetVideoResponse.convertDtoToResponse(videoService.getVideoMetadata(id)));
public ResponseEntity<VideoDto> getVideo(@RequestParam long id) {
return ResponseEntity.ok().body(videoService.getVideoMetadata(id));

}
}
30 changes: 0 additions & 30 deletions src/main/java/com/stream/controller/dto/login/LoginRequest.java

This file was deleted.

14 changes: 0 additions & 14 deletions src/main/java/com/stream/controller/dto/login/LoginResponse.java

This file was deleted.

30 changes: 0 additions & 30 deletions src/main/java/com/stream/controller/dto/signup/SignupRequest.java

This file was deleted.

18 changes: 0 additions & 18 deletions src/main/java/com/stream/controller/dto/signup/SignupResponse.java

This file was deleted.

This file was deleted.

This file was deleted.

4 changes: 2 additions & 2 deletions src/main/java/com/stream/domain/video/VideoService.java
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@ private Video getVideoById(long id) {
}

@Transactional
public List<Video> createVideo(Video... video) {
return videoRepository.saveAll(List.of(video));
public void createVideo(Video... video) {
videoRepository.saveAll(List.of(video));
}
}
4 changes: 0 additions & 4 deletions src/main/java/com/stream/domain/video/dto/VideoDto.java
Original file line number Diff line number Diff line change
Expand Up @@ -5,15 +5,11 @@
import com.stream.domain.video.Video;

import lombok.Builder;
import lombok.EqualsAndHashCode;
import lombok.Getter;
import lombok.NoArgsConstructor;
import lombok.ToString;

@Getter
@ToString
@NoArgsConstructor
@EqualsAndHashCode
public class VideoDto {
private long id;
private String fileTag;
Expand Down
15 changes: 0 additions & 15 deletions src/main/java/com/stream/exception/code/AuthExceptionCode.java

This file was deleted.

Loading

0 comments on commit 3118401

Please sign in to comment.