Fix serilog update #1443
Merged
Fix serilog update #1443
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
manandre
commented
Feb 1, 2025
| <PackageVersion Include="Microsoft.Extensions.Options" Version="8.0.2" /> | ||
| <PackageVersion Include="Microsoft.Extensions.Options.ConfigurationExtensions" Version="8.0.0" /> | ||
| <PackageVersion Include="Microsoft.Extensions.DependencyInjection" Version="8.0.1" /> | ||
| <PackageVersion Include="Microsoft.Extensions.Logging" Version="9.0.1" /> |
There was a problem hiding this comment.
The build logs contain new scary warnings:
warning : Microsoft.Extensions.Logging 9.0.1 doesn't support net6.0 and has not been tested with it. Consider upgrading your TargetFramework to net8.0 or later. You may also set <SuppressTfmSupportBuildWarnings>true</SuppressTfmSupportBuildWarnings> in the project file to ignore this warning and attempt to run in this unsupported configuration at your own risk.
Should we remove the support of the net6.0 TFM as it is officially EOL (see https://versionsof.net/core/6.0/)?
There was a problem hiding this comment.
The Microsoft.Extensions.Logging package does include .netstandard builds which should be fine. I imagine warnings like this are useful to push people to upgrade.
Should we remove the support of the net6.0 TFM as it is officially EOL (see https://versionsof.net/core/6.0/)?
I think we should. I need to make progress on OmniSharp/omnisharp-roslyn#2647 which would free O# to move to .net8.0 as well.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1410