Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create knapsack.py #25

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Create knapsack.py #25

wants to merge 1 commit into from

Conversation

dhirendrachoudhary
Copy link
Contributor

Returns the maximum value that can be put in a knapsack of capacity W

OmkarPathak
OmkarPathak requested changes Oct 16, 2019
View reviewed changes
Copy link
Owner

@OmkarPathak OmkarPathak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please make the following changes:

  • Change the file name to format as specified in other files: example: P05_FileName.py
  • Change the function names in case like: knap_sack and not knapSack

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@OmkarPathak OmkarPathak OmkarPathak requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@dhirendrachoudhary @OmkarPathak