Url Shortening simple web application #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…shed with the first commit
|
|
||
| class UrlMap(models.Model): | ||
| word = models.ForeignKey(Wordlist, blank=True, null=True) | ||
| url_actual = models.CharField(max_length=300) |
There was a problem hiding this comment.
@OmarManzoor
you should use the Django URL field here.
|
@OmarManzoor you missed the Test Cases here. (as stated in the doc) |
|
Made corrections and changes in the code by using a datetime for Words in the model to keep track of when that word was entered and updated. Also used a URL field for keeping track of the original url. Also made class based views and added some tests |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All the files committed and need a review