Minor review fixes from minimap review

[LiquidityC]

Summary by CodeRabbit

• Bug Fixes

  • Minimap now renders with proper transparency via blending, improving clarity when overlaid on the game view.
  • Removed the forced white backdrop, eliminating visual artifacts and reducing flicker during updates.
  • More consistent appearance across different backgrounds and themes.

• Chores

  • Suppressed minimap update debug logs for cleaner output and minor runtime overhead reduction.

[coderabbitai]

Walkthrough

Minimap rendering logic in src/gui.c was adjusted: blending is enabled for the minimap texture in init_sprites, the explicit white background setting and a debug log were removed from gui_update_minimap. No public interfaces changed.

Changes

Cohort / File(s)	Summary
Minimap rendering behavior src/gui.c	Added texture_set_blend_mode(..., SDL_BLENDMODE_BLEND) in init_sprites; removed SDL_SetRenderDrawColor(..., 255,255,255, SDL_ALPHA_OPAQUE) and a debug(...) call in gui_update_minimap.

Sequence Diagram(s)

sequenceDiagram
  autonumber
  participant GUI as GUI
  participant SDL as SDL/Renderer
  participant Tex as Minimap Texture

  rect rgba(200,230,255,0.2)
    note over GUI,Tex: Initialization
    GUI->>Tex: texture_set_blend_mode(..., SDL_BLENDMODE_BLEND)
  end

  rect rgba(220,255,220,0.2)
    note over GUI,SDL: Minimap Update (New)
    GUI->>SDL: Render minimap cells (no forced white clear)
    GUI->>SDL: Present/compose with blending
  end

Loading

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

• New minimap #126 — Touches the same minimap code paths (init_sprites and gui_update_minimap), likely connected to recent minimap behavior changes.

Suggested labels

enhancement

Poem

I hop through pixels, light and thin,
A blend of hues where walls begin.
No shouted logs, no painted snow—
Just layers soft that come and go.
Minimap whispers, clear yet shy;
I twitch my nose, and render by. 🐇✨

Pre-merge checks and finishing touches

❌ Failed checks (1 warning, 1 inconclusive)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.	You can run @coderabbitai generate docstrings to improve docstring coverage.
Title Check	❓ Inconclusive	The title “Minor review fixes from minimap review” is too generic and does not convey the specific changes made, such as enabling blending on the minimap texture or removing the white background clear and debug log. It references a review process rather than the actual functional updates, so a reader cannot discern the core update from the title alone.	Please update the title to clearly summarize the main changes, for example: “Enable blending on minimap texture and remove background clear and debug log” so that the primary functional updates are immediately evident.

✅ Passed checks (1 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.

✨ Finishing touches

• 📝 Generate docstrings

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch minor_review_fixes

---

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between efb0abb and 6f48e84.

📒 Files selected for processing (1)

• src/gui.c (1 hunks)

🧰 Additional context used

🧬 Code graph analysis (1)

src/gui.c (1)

src/texture.c (1)

• texture_set_blend_mode (227-232)

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (7)

• GitHub Check: Mac (Clang)
• GitHub Check: Ubuntu (Clang)
• GitHub Check: Windows (MSVC)
• GitHub Check: Mac (GCC)
• GitHub Check: Ubuntu (mingw)
• GitHub Check: Ubuntu (GCC)
• GitHub Check: Analyze (c-cpp)

🔇 Additional comments (1)

src/gui.c (1)

209-209: LGTM! Proper blend mode configuration for transparency.

Enabling SDL_BLENDMODE_BLEND for the minimap texture is correct and necessary for the alpha channel to work properly when rendering spaces with SDL_ALPHA_TRANSPARENT (e.g., lethal spaces at line 487 in gui_update_minimap).

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}