Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move check for root after options evaluation #116

Merged
merged 1 commit into from
Apr 29, 2023
Merged

Move check for root after options evaluation #116

merged 1 commit into from
Apr 29, 2023

Conversation

Olf0
Copy link
Owner

@Olf0 Olf0 commented Apr 29, 2023

No description provided.

@Olf0 Olf0 self-assigned this Apr 29, 2023
@Olf0 Olf0 added the enhancement New feature or request label Apr 29, 2023
Copy link
Owner Author

@Olf0 Olf0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Olf0 Olf0 merged commit 9a93222 into devel Apr 29, 2023
1 check passed
@Olf0 Olf0 deleted the move-root-check branch April 29, 2023 20:14
Olf0 added a commit that referenced this pull request May 3, 2023
* Update README.md

* Use POSIX shell arithmetic, `printf` instead of `echo`, omit quoting where obviously superfluous (#112)

* Use POSIX shell arithmetic

* Use POSIX arithmetic and omit quoting
  … where appropriate.

* Omit quoting where appropriate

* Omit quoting where appropriate

* `echo` --> `printf`

* `echo` --> `printf`

* `echo` --> `printf`

* Update tidy_log-dupes

* Optimise `sed` tapeworm from six to a single call

* Replace double quotes by single quotes, where …
  … appropriate

* More quoting enhancements

* Pre release version increase

* Do it correctly, use `eval`, see

https://pubs.opengroup.org/onlinepubs/9699919799/utilities/V3_chap02.html#tag_18_19

* `grep -vx ''`→`fgrep -vx ''`

* Unify quoting

* Unify quoting

* Unify

* Unify quoting

* Update post_sfos-upgrade

* New intro

* New intro

* Update tidy_log-dupes

* Update post_sfos-upgrade

* Update sfos-upgrade

* Update tidy_log-dupes

* Update post_sfos-upgrade

* Move up from `/usr/bin` to `/bin` (#113)

* Rename usr/bin/post_sfos-upgrade to bin/post_sfos-upgrade

* Rename usr/bin/sfos-upgrade to bin/sfos-upgrade

* Rename usr/bin/tidy_log-dupes to bin/tidy_log-dupes

* Executables are now originally in `/bin` instead of `/usr/bin`

* Call it "SailfishOS:Chum metadata definition"

* Update sfos-upgrade.spec

* Move icon from `icon` to `.icon` (#114)

* Move icon from `icon` to `.icon`

* Move icon directory from icon to .icon

---------

Co-authored-by: olf (Olf0) <[email protected]>

* Update according to version 1 of the SailfishOS:Chum metadata definition

https://github.com/sailfishos-chum/main/blob/38e1f19a1617db04243d0b625a1ca7e0ae0483c5/Metadata.md

* Remove entries obsoleted by commit 6ccb592

"Update according to version 1 of the SailfishOS:Chum metadata definition"

* Revert commit b3bbdc0

* Simplify some `cut`s to `${foo%…}` rsp. `${bar#…}`

* Adapting to Jolla's perpetual changing of formats …
  … and interfaces, this time https://github.com/sailfishos/docs.sailfishos.org/pull/297/files
  Luckily the concluding `sort -u` already handled that well, now make more obvious what has to be done.

* Expand comment

* Enhance comments with new knowledge about `sort`

* Move check for root after options evaluation (#116)

* `basename $0`→`${0##*/}`

* `basename $0`→`${0##*/}`

* "per"→"by" in comments

* Add comment

* Enhance comment

* Better wording: "field" -> "tag"
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant