-
Notifications
You must be signed in to change notification settings - Fork 94
Emoji font #193
base: develop
Are you sure you want to change the base?
Emoji font #193
Conversation
Hmmm how does this behave on mobile phones 🤔 . I'll do some testing. Also on emojione, it is free license but with some very harsh limitations https://github.com/joypixels/emojione-assets/blob/master/LICENSE.md , so we've gotta take a look at those too before merging. |
Yeah license does require attribution to use. It's also quite large (about 18 MiB - even after zip compression as used in APKs) so this might not be the best option. |
Another option might be to use Google's NotoColorEmoji font, licensed under the SIL Open Font License, available for download here: https://www.google.com/get/noto/#emoji-zsye-color |
So maybe we could use this https://github.com/eosrei/twemoji-color-font |
dafa68d
to
360edd9
Compare
I've rebased this onto the current |
Twemoji is also CC-BY 4.0, so an attribution is required. They, however, mention that they "will accept a mention in a project README or an 'About' section or footer on a website. In mobile applications, a common place would be in the Settings/About section (for example, see the mobile Twitter application Settings->About->Legal section). We would consider a mention in the HTML/JS source sufficient also." @999eagle |
This PR adds a font for emoji and changes some text styles to fall back to this font. That way, missing glyphs in the main font (for example emoji) will be rendered using the emoji font.
The font used is EmojiOne from https://github.com/maximbaz/emojione-fonts, with that it's under a CC-BY-4.0 license so it needs attribution to use.