[Word] (Shapes) Work with text boxes #977
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlexJerabek
approved these changes
Apr 25, 2025
| if (shapes.items.length > 0) { | ||
| shapes.items.forEach(function(shape, index) { | ||
| if (shape.type == Word.ShapeType.textBox) { | ||
| console.log(`Shape ${index + 1} in header has a text box. Properties:`, shape); |
There was a problem hiding this comment.
Why do we want to log the index like it's not zero-based?
Comment on lines
235
to
240
| <button id="insert-text-box-in-header-at-first-paragraph" class="ms-Button"> | ||
| <span class="ms-Button-label">Insert text box into header</span> | ||
| </button> | ||
| <button id="get-text-box-in-header" class="ms-Button"> | ||
| <span class="ms-Button-label">Get text boxes in header</span> | ||
| </button> |
There was a problem hiding this comment.
Since there are so many buttons, consider putting the buttons for the header text box in a different section.
Co-authored-by: Alex Jerabek <[email protected]>
AlexJerabek
approved these changes
Apr 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Will add API mapping later.