Remove directory change from teams-test-app build command #2918
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
size-limit report 📦
|
|
Ran this branch manually against our pipeline and it seems to be all green! |
JoshuaLai
approved these changes
Nov 10, 2025
JoshuaLai
left a comment
JoshuaLai
left a comment
There was a problem hiding this comment.
Ran and tested this a few time on the pipeline and had a 100% success rate so comfortable approving and monitoring further.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For more information about how to contribute to this repo, visit this page.
Description
The teams-test-app's
validate-test-schemacommand (invoked by itsbuildcommand) contains acdcommand to move up to the root of the repo to runvalidate-test-schema.teams-test-appis intermittently failing at the build step due to a'webpack' is not recognized as an internal or external command, teams-test-app: operable program or batch file.error. This directory change seems like the only thing that differs between this build and the other packages in the repo, so I'd like to try removing it and see if our build success rate improves.Main changes in the PR:
cd ../..command from teams-test-app's build script.Validation
Validation performed:
Unit Tests added:
No, no source code changes
End-to-end tests added:
No
Additional Requirements
Change file added:
No, test app update