This repository has been archived by the owner on Jun 18, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 562
issue #580 : support for configured TLS and cipherSuites #628
Open
pheenomenon
wants to merge
1
commit into
OfficeDev:master
Choose a base branch
from
pheenomenon:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #628 +/- ##
============================================
+ Coverage 10.43% 10.43% +<.01%
- Complexity 0 471 +471
============================================
Files 550 550
Lines 20436 20444 +8
Branches 2626 2084 -542
============================================
+ Hits 2132 2134 +2
- Misses 18151 18155 +4
- Partials 153 155 +2
Continue to review full report at Codecov.
|
2 similar comments
so sad having such great prs go unnoticed, can you please allow a 3rd party maintainer |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fix is for #580
This PR has fix as per #2 below.
Few options to fix this are:
1] stop setting ConnectionManager and set useSystemProperties() while building HttpClients, in which case HttpClientBuilder will invoke the code to read systemProperties.
reuseStrategyCopy = new SSLConnectionSocketFactory((SSLSocketFactory)SSLSocketFactory.getDefault(), keepAliveStrategyCopy, targetAuthStrategyCopy, (HostnameVerifier)proxyAuthStrategyCopy);
2] Another approach is to update EwsSSLProtocolSocketFactory.build() to support the call to SSLConnectionSocketFactory constructor using SSL protocol and cipherSuite.