Open
Conversation
YugalPradhan31
changed the title
YugalPradhan31
changed the title
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request creates a new TypeScript bot file upload sample using the modern Teams SDK (@microsoft/teams.apps), replacing the old JavaScript implementation that used Bot Framework v4.
Changes:
- Removes the old Bot Framework v4-based JavaScript implementation
- Adds a new TypeScript sample using
@microsoft/teams.appsSDK - Updates sample metadata and documentation
Reviewed changes
Copilot reviewed 35 out of 46 changed files in this pull request and generated 6 comments.
Show a summary per file
| File | Description |
|---|---|
| samples/bot-file-upload/nodejs/bot-file-upload/index.ts | New TypeScript implementation with Teams SDK handlers for file upload/download |
| samples/bot-file-upload/nodejs/bot-file-upload/package.json | New package configuration for TypeScript sample |
| samples/bot-file-upload/nodejs/bot-file-upload/README.md | Documentation for the new TypeScript sample |
| samples/bot-file-upload/nodejs/bot-file-upload/assets/sample.json | Updated sample metadata |
| samples/bot-file-upload/nodejs/bot-file-upload/.env | Environment configuration template |
| samples/bot-file-upload/nodejs/* (deleted files) | Removed old Bot Framework v4 implementation and configuration |
Comments suppressed due to low confidence (1)
samples/bot-file-upload/nodejs/bot-file-upload/assets/sample.json:12
- The creationDateTime and updateDateTime are set to future dates (2026-01-28). According to the internal knowledge, the current date is January 29, 2026, but setting the creationDateTime to 2026-01-28 for a new sample is problematic. The creationDateTime should reflect when the sample was originally created or use a realistic past date.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
lilyydu
requested changes
Feb 6, 2026
YugalPradhan31
changed the title
lilyydu
reviewed
Feb 10, 2026
| return stats.size; | ||
| } catch (error: any) { | ||
| console.error('Error retrieving file size:', error.message); | ||
| throw new Error('Failed to retrieve file size'); |
lilyydu
reviewed
Feb 10, 2026
Contributor
Author
|
I have tested this sample on Microsoft Teams and Agents Playground, and it is working as expected. The "file upload" feature does not work in Agents Playground due to platform limitations. Please find the attached screenshot as proof of successful testing. Agents Playground: File Upload Functionality in Teams: |
lilyydu
reviewed
Feb 13, 2026
| } | ||
|
|
||
| // Downloads content from a URL and saves it to the specified file path | ||
| async function WriteFile(contentUrl: string, config: any, filePath: string): Promise<void> { |
Collaborator
There was a problem hiding this comment.
methods in typescript should be camelcase
lilyydu
reviewed
Feb 13, 2026
| @@ -0,0 +1,22 @@ | |||
| # Environment variables | |||
| .env | |||
Collaborator
There was a problem hiding this comment.
remove, only .gitignore in root
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.