Coordinate the Block and MEL Validators#4434
Open
ganeshvanahalli wants to merge 5 commits intomel-validator-createvalidationentryfrom
Open
Coordinate the Block and MEL Validators#4434ganeshvanahalli wants to merge 5 commits intomel-validator-createvalidationentryfrom
ganeshvanahalli wants to merge 5 commits intomel-validator-createvalidationentryfrom
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## mel-validator-createvalidationentry #4434 +/- ##
=======================================================================
+ Coverage 28.32% 28.83% +0.51%
=======================================================================
Files 500 500
Lines 59305 59439 +134
=======================================================================
+ Hits 16796 17138 +342
+ Misses 39378 39171 -207
+ Partials 3131 3130 -1 |
Contributor
❌ 9 Tests Failed:
View the top 3 failed tests by shortest run time
📣 Thoughts on this report? Let Codecov know! | Powered by Codecov |
ganeshvanahalli
commented
Feb 26, 2026
ganeshvanahalli
commented
Feb 26, 2026
rauljordan
requested changes
Feb 26, 2026
Contributor
rauljordan
left a comment
rauljordan
left a comment
There was a problem hiding this comment.
Looks great so far! Very close to completion
| stack, | ||
| latestWasmModuleRoot, | ||
| ) | ||
| if messageExtractor != nil { |
Contributor
There was a problem hiding this comment.
This code duplication can be solved if stateless block validator takes in an interface and you can just pass that in. You can define a var above this function and with an if set it to either messageExtractor or inboxReader + tracker
system_tests/common_test.go
Outdated
| b.nodeConfig.MessageExtraction.Enable = false // Skip running in MEL mode for block validator tests | ||
| } | ||
| } | ||
| func UseUnifiedModuleRoot(nodeConfig *arbnode.Config) bool { |
Contributor
There was a problem hiding this comment.
Can this instead be a method on arbnode.Config ?
Contributor
Author
There was a problem hiding this comment.
great idea! added this
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds the required wiring for MEL validator to be started and used by node and block-validator. It also makes it that block validator sets the target block number for MEL validator up to which the MEL validator will validate message extraction.
[Pending adding a system test with reorg handling by validators]
Resolves NIT-4535