Skip to content

Comments

Merge geth v1.17.0#4416

Open
ganeshvanahalli wants to merge 2 commits intomasterfrom
merge-v1.17.0
Open

Merge geth v1.17.0#4416
ganeshvanahalli wants to merge 2 commits intomasterfrom
merge-v1.17.0

Conversation

@ganeshvanahalli
Copy link
Contributor

@ganeshvanahalli ganeshvanahalli commented Feb 20, 2026

pulls in OffchainLabs/go-ethereum#627 that is up-to-date with upstream go-ethereum version 1.17.0

Resolves NIT-4484

@codecov
Copy link

codecov bot commented Feb 20, 2026

Codecov Report

❌ Patch coverage is 33.33333% with 8 lines in your changes missing coverage. Please review.
✅ Project coverage is 33.10%. Comparing base (3b8bfe6) to head (bb65926).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4416      +/-   ##
==========================================
+ Coverage   32.90%   33.10%   +0.20%     
==========================================
  Files         489      489              
  Lines       58146    58141       -5     
==========================================
+ Hits        19131    19249     +118     
+ Misses      35671    35529     -142     
- Partials     3344     3363      +19     

@github-actions
Copy link
Contributor

github-actions bot commented Feb 20, 2026

❌ 6 Tests Failed:

Tests completed Failed Passed Skipped
4220 6 4214 0
View the top 3 failed tests by shortest run time
TestNitroNodeVersionAlerter
Stack Traces | 0.660s run time
... [CONTENT TRUNCATED: Keeping last 20 lines]
INFO [02-20|19:09:11.856] Imported new potential chain segment     number=69  hash=8a50f5..d89900 blocks=1  txs=1   mgas=0.146  elapsed=125.321ms    mgasps=1.165    triediffs=415.88KiB triedirty=0.00B
INFO [02-20|19:09:11.857] Chain head was updated                   number=69  hash=8a50f5..d89900 root=047cc8..a13db4 elapsed="117.219µs"
INFO [02-20|19:09:11.875] Imported new potential chain segment     number=82  hash=fa2d89..f4adb4 blocks=1  txs=1   mgas=0.021  elapsed=23.259ms     mgasps=0.903    triediffs=357.70KiB triedirty=0.00B
INFO [02-20|19:09:11.876] Chain head was updated                   number=82  hash=fa2d89..f4adb4 root=b9883c..f79d48 elapsed="87.965µs"
INFO [02-20|19:09:11.881] Batch overflow: compressed size limit exceeded compressedSize=247 limit=186 isHeader=false
INFO [02-20|19:09:11.895] Submitted transaction                    hash=0xe4d91d8cf8049714378bbbbc1aacf280e384a4c17c067145a39b0ac091454e1d from=0xaF24Ca6c2831f4d4F629418b50C227DF0885613A nonce=54  recipient=0xaF24Ca6c2831f4d4F629418b50C227DF0885613A value=1,000,000,000,000
WARN [02-20|19:09:11.895] Served eth_sendRawTransactionConditional reqid=1146 duration=43.838151ms   err="Storage slot value condition not met"
INFO [02-20|19:09:11.896] Batch overflow: compressed size limit exceeded compressedSize=247 limit=186 isHeader=false
WARN [02-20|19:09:11.897] error applying transaction               tx="{\"type\":\"0x2\",\"chainId\":\"0x64aba\",\"nonce\":\"0x10e\",\"to\":\"0x0c709f340f0bb2e361229e345b7e26999d0969ab\",\"gas\":\"0x7a1200\",\"gasPrice\":\"0x0\",\"maxPriorityFeePerGas\":\"0xbebc200\",\"maxFeePerGas\":\"0xbebc200\",\"value\":\"0xe8d4a51000\",\"input\":\"0x\",\"accessList\":[],\"v\":\"0x0\",\"r\":\"0xdf4963485a7283d0654d893448fa218303e41e959f161d1347a0a56d6b98c0e4\",\"s\":\"0x4f968ee6eb6659dabed2006229e9299f053ccd70551e95a1d8a231a1ec627bb9\",\"yParity\":\"0x0\",\"hash\":\"0x2712e5c45d81800feae08d549320a6c995bc9c0e3d3f7eb5b306a8455ff58d59\"}" err="Storage slot value condition not met"
INFO [02-20|19:09:11.899] Starting work on payload                 id=0x036b364253b83458
INFO [02-20|19:09:11.899] InboxTracker                             sequencerBatchCount=8  messageCount=10  l1Block=37  l1Timestamp=2026-02-20T19:09:10+0000
INFO [02-20|19:09:11.900] Updated payload                          id=0x036b364253b83458 number=83  hash=ba9f2a..364c0f txs=1   withdrawals=0 gas=21000      fees=0.002099942082 root=7d339e..f6cd61 elapsed=1.226ms
INFO [02-20|19:09:11.901] Stopping work on payload                 id=0x036b364253b83458 reason=delivery
INFO [02-20|19:09:11.902] Imported new potential chain segment     number=83  hash=ba9f2a..364c0f blocks=1  txs=1   mgas=0.021  elapsed=1.563ms      mgasps=13.434   triediffs=361.76KiB triedirty=0.00B
INFO [02-20|19:09:11.902] Chain head was updated                   number=83  hash=ba9f2a..364c0f root=7d339e..f6cd61 elapsed="83.586µs"
WARN [02-20|19:09:11.903] Served eth_sendRawTransactionConditional reqid=1147 duration=7.830444ms    err="Storage slot value condition not met"
--- FAIL: TestNitroNodeVersionAlerter (0.66s)
WARN [02-20|19:09:11.904] Sequencer ReadFromTxQueueTimeout is higher than MaxBlockSpeed ReadFromTxQueueTimeout=1s MaxBlockSpeed=10ms
WARN [02-20|19:09:11.904] Sanitizing invalid node buffer size      provided=1.00GiB updated=256.00MiB
INFO [02-20|19:09:11.904] Disabling diff mode trie node history encoding
TestVersion40
Stack Traces | 6.490s run time
... [CONTENT TRUNCATED: Keeping last 20 lines]
        	/opt/hostedtoolcache/go/1.25.6/x64/src/testing/testing.go:1934 +0xea
        created by testing.(*T).Run in goroutine 1
        	/opt/hostedtoolcache/go/1.25.6/x64/src/testing/testing.go:1997 +0x465
        
    precompile_inclusion_test.go:94: �[31;1m [] execution aborted (timeout = 5s) �[0;0m
INFO [02-20|19:06:35.786] Writing cached state to disk             block=1   hash=84760f..ef333a root=d45d64..4e7811
INFO [02-20|19:06:35.786] Persisted trie from memory database      nodes=23  flushnodes=0 size=3.61KiB   flushsize=0.00B time="117.038µs" flushtime=0s gcnodes=0 gcsize=0.00B gctime="1.724µs"   livenodes=0    livesize=0.00B
INFO [02-20|19:06:35.786] Writing cached state to disk             block=1   hash=84760f..ef333a root=d45d64..4e7811
INFO [02-20|19:06:35.786] Persisted trie from memory database      nodes=0   flushnodes=0 size=0.00B     flushsize=0.00B time="1.282µs"   flushtime=0s gcnodes=0 gcsize=0.00B gctime=0s          livenodes=0    livesize=0.00B
INFO [02-20|19:06:35.787] Writing snapshot state to disk           root=28fb26..40a768
INFO [02-20|19:06:35.787] Persisted trie from memory database      nodes=0   flushnodes=0 size=0.00B     flushsize=0.00B time=752ns       flushtime=0s gcnodes=0 gcsize=0.00B gctime=0s          livenodes=0    livesize=0.00B
INFO [02-20|19:06:35.787] Blockchain stopped
INFO [02-20|19:06:35.787] Updated payload                          id=0x03f69f363c859913 number=9   hash=49a5f1..318ea4 txs=2  withdrawals=0 gas=4,242,471  fees=4.242471e-06   root=bf5f91..01890a elapsed=11.855ms
INFO [02-20|19:06:35.789] Submitted contract creation              hash=0x219cf3e880a038dd3d8a8c0766c4cd7e93f44b7229b0814333b4cd9c429873c7 from=0x57Ff0F473737a1c161bfF9efDF016F7991585088 nonce=6   contract=0x8A9dA5e5455B307e99515702E3E753809e26A71b value=0
INFO [02-20|19:06:35.789] Submitted transaction                    hash=0xd657c184a27e7fa9b9085c017fd938f02af42693b2306abbb89c5185357064a0 from=0xaF24Ca6c2831f4d4F629418b50C227DF0885613A nonce=730 recipient=0x0C709F340F0BB2e361229e345B7e26999d0969Ab value=1
INFO [02-20|19:06:35.789] Stopping work on payload                 id=0x03f69f363c859913 reason=delivery
INFO [02-20|19:06:35.790] Starting work on payload                 id=0x035f1fb57146010b
INFO [02-20|19:06:35.791] Updated payload                          id=0x035f1fb57146010b number=10  hash=09871a..c5dc38 txs=1  withdrawals=0 gas=580,911    fees=5.80911e-07    root=0296eb..49d81a elapsed="631.43µs"
INFO [02-20|19:06:35.791] Imported new potential chain segment     number=9   hash=49a5f1..318ea4 blocks=1  txs=2  mgas=4.242  elapsed=3.507ms      mgasps=1209.531 triediffs=28.47KiB  triedirty=0.00B
--- FAIL: TestVersion40 (6.49s)
TestAnyTrustRekey
Stack Traces | 11.720s run time
... [CONTENT TRUNCATED: Keeping last 20 lines]
        created by testing.(*T).Run in goroutine 1
        	/opt/hostedtoolcache/go/1.25.6/x64/src/testing/testing.go:1997 +0x465
        
    common_test.go:935: �[31;1m [failed to deploy ArbDebug] nonce too low: address 0x26E554a8acF9003b83495c7f45F06edCB803d4e3, tx: 0 state: 3 �[0;0m
INFO [02-20|19:08:46.293] Updated payload                          id=0x039636ff012847eb number=7  hash=fcf2c5..741eb5 txs=1   withdrawals=0 gas=580,911    fees=5.80911e-07    root=a9422b..d74929 elapsed=1.293ms
INFO [02-20|19:08:46.293] Stopping work on payload                 id=0x039636ff012847eb reason=delivery
WARN [02-20|19:08:46.293] Error getting finality msg count         scenario=safe err="context canceled"
INFO [02-20|19:08:46.293] Imported new potential chain segment     number=5  hash=70aa7e..41ee3e blocks=1  txs=1   mgas=4.765  elapsed=15.358ms    mgasps=310.286  triediffs=15.13KiB  triedirty=0.00B
INFO [02-20|19:08:46.294] Submitted contract creation              hash=0x2de2774e30ebefd5c3fce7127bbbabee765b7e4911f73bd38f09fe468d554ed5 from=0x57Ff0F473737a1c161bfF9efDF016F7991585088 nonce=4   contract=0x68c55BbCAbb6EC7D623c420B6169CF277Fe040b5 value=0
INFO [02-20|19:08:46.294] Chain head was updated                   number=5  hash=70aa7e..41ee3e root=f48c46..6346fa elapsed="408.012µs"
--- FAIL: TestAnyTrustRekey (11.72s)
INFO [02-20|19:08:46.295] New Key                                  name=Faucet              Address=0xaF24Ca6c2831f4d4F629418b50C227DF0885613A
INFO [02-20|19:08:46.295] Starting work on payload                 id=0x03d8015e7ff8562d
INFO [02-20|19:08:46.295] New Key                                  name=RollupOwner         Address=0x57Ff0F473737a1c161bfF9efDF016F7991585088
INFO [02-20|19:08:46.295] New Key                                  name=Sequencer           Address=0xb386a74Dcab67b66F8AC07B4f08365d37495Dd23
INFO [02-20|19:08:46.295] New Key                                  name=Validator           Address=0x83FFCFaCE2Fb0E1286686815503608A16EF41e47
INFO [02-20|19:08:46.295] New Key                                  name=User                Address=0x7E23C8862920797d81916d62c274dd9217113e28
INFO [02-20|19:08:46.296] Allocated trie memory caches             clean=154.00MiB dirty=256.00MiB
INFO [02-20|19:08:46.296] State schema set to default              scheme=path
INFO [02-20|19:08:46.296] Submitted transaction                    hash=0x754c25f0c4f02e6b7bce958cc4a3da56ab9ae7cd316e7f9dcf0000f8d68c2b0a from=0x57Ff0F473737a1c161bfF9efDF016F7991585088 nonce=28  recipient=0x4C4Ac1257945782bf52A724e75687d9010C770DE value=0

📣 Thoughts on this report? Let Codecov know! | Powered by Codecov

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants