Support for rollup mode when using fee token #252
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…itro-contracts into custom-fee-rollup
…itro-contracts into custom-fee-rollup
…itro-contracts into custom-fee-rollup
gzeoneth
reviewed
Sep 27, 2024
| * @dev For example, parent chain's native token is ETH, fee token is DAI. If price of 1ETH = 2000DAI, then function should return 2000*1e18. | ||
| * If fee token is USDC instead and price of 1ETH = 2000USDC, function should still return 2000*1e18, no matter that USDC uses 6 decimals. | ||
| */ | ||
| function getExchangeRate() external returns (uint256); |
There was a problem hiding this comment.
instead of a getter that return spot rate, I think it make more sense to have a mutable method spendingInEth(uint256 wei, address spender) that take the number of eth spent as input and return the number of token spent. This allow the pricer to do more complex internal accounting if needed.
There was a problem hiding this comment.
As we discussed, we can probably satisfy all use-cases with getExchangeRate(). It's mutable so it enables internal accounting. Gas reporting hooks can be used to update state and account for which state is updated can be tx.origin or 'spender' as reported by the hook.
Merged
gzeoneth
requested changes
Nov 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This feature adds support to run fee token based Orbit chains in rollup mode. Previously only Anytrust mode was supported when fee token is used. This is because ArbO assumes that the asset used to pay for batch posting on parent chain is the same asset which is used as native asset on the child chain. If batch poster spends 0.01 ETH to post batch on the parent chain, it will be reimbursed 0.01 ETH on the child chain. However this approach is not valid when fee token is used. Reimbursing batch poster with 0.01 fee token after it has spent 0.01 ETH would be fine only if exchange rate between ETH and fee token was 1:1. In practice this will not be the case, so we’re introducing a way to get the actual exchange rate on-chain and use it to correctly reimburse the batch poster.
This PR enables SequencerInbox to fetch the feeToken:nativeToken exchange rate from the external source called
feeTokenPricerwhich is set by the chain owner. Pricer needs to implement a single functiongetExchangeRate() returns(uint256). In practice, pricer can use Chainlink, amm twap, constant price, or any other approach to report exchange rate.