feat(SequencerInbox): gas optimization#22
Closed
shotaronowhere wants to merge 2 commits intoOffchainLabs:developfrom
Closed
feat(SequencerInbox): gas optimization#22shotaronowhere wants to merge 2 commits intoOffchainLabs:developfrom
shotaronowhere wants to merge 2 commits intoOffchainLabs:developfrom
Conversation
Member
|
LGTM tho will merge later since this included a storage modification |
Contributor
Author
|
PR is stale, optimization is now in #68 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR simply packs the MaxTimeVariation members into a single slot.
Each time the sequencer posts a batch, the time boundary is calculated accessing each member of MaxTimeVariation.
Timestamps fit in uint32 data types, this is sufficient for atleast 80 years. I see uint64 is the time data type convention used in the repo so this is suitable for the MaxTimeVariation.delaySeconds/futureSeconds.
Regarding blocktime, even if Arbitrum settled on BSC (~3 second block time) or Solana (400 millisecond block time), uint64 is more than sufficient for million millions of years.
This PR saves approximately 6300 gas per sequencer batch posted --- about 2 billion gas, or 20 - 60 eth since Nitro launched.