feat: 4844 implementation #109
Conversation
Added postupgradeinit for the challenge manager
| ) | ||
| { | ||
| bytes32[] memory dataHashes = reader4844.getDataHashes(); | ||
| if (dataHashes.length == 0) revert MissingDataHashes(); |
There was a problem hiding this comment.
No change necessary, I just wanted to point out that this is a great check and we should keep it. Specifically, I'm worried that some RPC providers that aren't ready for 4844 yet might drop the blobVersionedHashes field from eth_estimateGas and would otherwise return too low of an estimate. Reverting here prevents that from happening.
There was a problem hiding this comment.
Interesting point. In the GasRefundEnabled we branch based on this statement so that would give the wrong gas estimate. But that code path should only be triggered when this one reverts, so we should be fine there.
Support zero basefee for gas estimation
Fix SequencerInboxStubCreator
| ) | ||
| { | ||
| bytes32[] memory dataHashes = reader4844.getDataHashes(); | ||
| if (dataHashes.length == 0) revert MissingDataHashes(); |
There was a problem hiding this comment.
Interesting point. In the GasRefundEnabled we branch based on this statement so that would give the wrong gas estimate. But that code path should only be triggered when this one reverts, so we should be fine there.
misc: spending report logic and interface
Was #96, added 3b59719 to remove certain sequencer inbox optimizations.