Filter transaction #377
Filter transaction #377
Conversation
ganeshvanahalli
requested review from
PlasmaPower,
joshuacolvin0,
eljobe and
amsanghi
core/state/statedb.go
Outdated
| @@ -86,6 +90,7 @@ func (m *mutation) isDelete() bool { | |||
| // commit states. | |||
| type StateDB struct { | |||
| arbExtraData *ArbitrumExtraData // must be a pointer - can't be a part of StateDB allocation, otherwise its finalizer might not get called | |||
| arbTxFilter bool | |||
There was a problem hiding this comment.
I believe statedb also has a Copy or Clone method that also needs modified to copy this field. Also, perhaps it should be in arbExtraData for clarity?
There was a problem hiding this comment.
moved it to arbExtraData for clarity, this also avoids merge conflicts in the future
|
Also, I think this flag might need to survive reverts |
This is handled by persisting the flag in revisions |
|
I'm not sure, wouldn't that mean the flag could get reset to false if a contract reverts? |
if a contract reverts such that it leads to a tx failure, then we dont have to worry about the boolean as statedb would be reset to previous snapshot in the block_processor anyway. and if the contract revert doesn't cause the tx failure then geth would've taken a statedb snapshot before such an execution right? so that it can revert back to it? in which case revisions would persist the boolean's value |
ganeshvanahalli
dismissed stale reviews from PlasmaPower and tsahee
addressed
This PR enables filtering of malicious transactions and blocks via a
stateDBobjectCorresponding Nitro PR- OffchainLabs/nitro#2807
Part of NIT-2848