replace MessageRunMode with a struct #373
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
magicxyyz
commented
Nov 15, 2024
tsahee
requested changes
Dec 31, 2024
Member
|
Assigning to @magicxyyz to clean up the conflicts and resolve review feedback. |
Contributor
|
I want this to wait until after we cut the Arbos-40 WasmModuleRoot |
magicxyyz
commented
Jun 24, 2025
magicxyyz
commented
Jun 24, 2025
|
|
||
| func ApplyTransactionWithResultFilter(evm *vm.EVM, gp *GasPool, statedb *state.StateDB, header *types.Header, tx *types.Transaction, usedGas *uint64, runMode MessageRunMode, resultFilter func(*ExecutionResult) error) (*types.Receipt, *ExecutionResult, error) { | ||
| msg, err := TransactionToMessage(tx, types.MakeSigner(evm.ChainConfig(), header.Number, header.Time, evm.Context.ArbOSVersion), header.BaseFee, runMode) | ||
| func ApplyTransactionWithResultFilter(evm *vm.EVM, gp *GasPool, statedb *state.StateDB, header *types.Header, tx *types.Transaction, usedGas *uint64, runCtx *MessageRunContext, resultFilter func(*ExecutionResult) error) (*types.Receipt, *ExecutionResult, error) { |
Contributor
Author
There was a problem hiding this comment.
can we put resultFilter into MessageRunContext? (not urgent)
tsahee
previously approved these changes
Jun 26, 2025
Contributor
tsahee
left a comment
tsahee
left a comment
There was a problem hiding this comment.
another small suggestion for later
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR:
MessageRunModeenum withMessageRunContextstruct, that apart from run mode now contains wasm cache tag and wasm targets listcachingDBandethdb.DatabaseResolves NIT-2827