address PR comments

core/state/statedb.go

@@ -240,7 +240,7 @@ func (s *StateDB) FilterTx(withBlock bool) {
 	}
 }
 
-func (s *StateDB) IsTxInvalid() bool {
+func (s *StateDB) IsTxFiltered() bool {
 	return s.arbTxFilter == txFiltered
 }
 
@@ -842,6 +842,9 @@ func (s *StateDB) Copy() *StateDB {
 
 // Snapshot returns an identifier for the current revision of the state.
 func (s *StateDB) Snapshot() int {
+	if s.arbTxFilter == txFiltered {
+		panic("trying to create a new snapshot when the previous transaction applied to this state was filtered. RevertToSnapshot should be called before moving on to the next transaction")
+	}
 	id := s.nextRevisionId
 	s.nextRevisionId++
 	s.validRevisions = append(s.validRevisions, revision{id, s.journal.length(), new(big.Int).Set(s.arbExtraData.unexpectedBalanceDelta)})
@@ -1248,7 +1251,7 @@ func (s *StateDB) GetTrie() Trie {
 // The associated block number of the state transition is also provided
 // for more chain context.
 func (s *StateDB) Commit(block uint64, deleteEmptyObjects bool) (common.Hash, error) {
-	if s.arbTxFilter == blockFiltered {
+	if s.arbTxFilter == blockFiltered || s.arbTxFilter == txFiltered {
 		return common.Hash{}, ErrArbTxFilter
 	}
 	// Short circuit in case any database failure occurred earlier.

core/vm/interface.go

@@ -50,7 +50,7 @@ type StateDB interface {
 
 	// Arbitrum
 	FilterTx(bool)
-	IsTxInvalid() bool
+	IsTxFiltered() bool
 
 	Deterministic() bool
 	Database() state.Database